Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python311 #74

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python311.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

  • gnuradio
    and potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3329844940, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@chrisburr
Copy link
Member

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/lxml-feedstock/actions/runs/3331207334.

@mbargull
Copy link
Member

@conda-forge-admin, please rerender

@chrisburr
Copy link
Member

I think this is failing as a result of conda-forge/libxml2-feedstock#66

chrisburr and others added 4 commits October 27, 2022 10:02
To make it use pkg-config rather than xml2-config (which is not
available in our libxml2 builds on Windows).
@mbargull
Copy link
Member

libxslt does not have pkg-config files and I believe we have the fallback to xml2-config because of that.

@h-vetinari
Copy link
Member

I think this is failing as a result of conda-forge/libxml2-feedstock#66

CC @hmaarrfk

@hmaarrfk
Copy link
Contributor

Thank you for pinging me . I guess PKG config should be dealing with this. Or you should add a cflag manually to add the subdirectory yourself.

@hmaarrfk
Copy link
Contributor

It is very possible that the PKGconfig file is wrong on windows

@mbargull
Copy link
Member

It is very possible that the PKGconfig file is wrong on windows

libxml-2.0.pc is okay.

I'm working on libxslt.pc.

libxslt does not have pkg-config files and I believe we have the fallback to xml2-config because of that.

@hmaarrfk
Copy link
Contributor

I'm working on libxslt.pc.

What feedstock should generate this file

@mbargull
Copy link
Member

@mbargull
Copy link
Member

Windows builds seem to need some more massaging. I'll try out a few things in an hours or so.

@mbargull
Copy link
Member

@conda-forge-admin, please restart ci

@mbargull
Copy link
Member

@conda-forge-admin, please rerender
... for good measure

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/lxml-feedstock/actions/runs/3339969207.

@mbargull
Copy link
Member

Feel free to merge if the changes look alright to you.

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

we moved up the pin of libxml2 to 2.10

Specifying anything on the same line will remove the global pin :/

@mbargull
Copy link
Member

we moved up the pin of libxml2 to 2.10

Thanks for fixing this.

Specifying anything on the same line will remove the global pin :/

Yep, when those constraints are necessary, always double the entry, e.g.,

 - libxml2 !=2.9.11, !=2.9.12
+- libxml2

when the pinning may still produce 2.9.* ones (which now isn't the case anymore).

script: {{ PYTHON }} -m pip install . -vv
number: 1
script:
- set "PKG_CONFIG_PATH=%LIBRARY_LIB%\pkgconfig;%LIBRARY_PREFIX%\share\pkgconfig" # [win]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we patch pkg_config to include this automatically?

@hmaarrfk hmaarrfk merged commit d443e60 into conda-forge:main Oct 27, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-python311-0-1_ha49691 branch October 27, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants