Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Matplotlib 3.9.0rc1 #373

Open
wants to merge 41 commits into
base: rc
Choose a base branch
from
Open

Conversation

dopplershift
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

dopplershift and others added 30 commits February 14, 2023 12:31
Matches changes in upstream with 3.8.0 final.
automerged PR by conda-forge/automerge-action
Reflect PSF-2.0 being an official SPDX license
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tacaswell
Copy link
Contributor

@conda-forge-admin, please rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/matplotlib-feedstock/actions/runs/8842524900.

@tacaswell
Copy link
Contributor

ImportError: /home/conda/feedstock_root/build_artifacts/matplotlib-suite_1714079322516/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/matplotlib/_path.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN3agg10curve3_div4initEdddddd

That looks real 😱

@tacaswell
Copy link
Contributor

It also looks like atleast some of the builds are trying to build our own freetype.

@QuLogic
Copy link
Member

QuLogic commented May 1, 2024

mplsetup.cfg is no longer used; config settings need to be passed in to the build backend. https://matplotlib.org/devdocs/api/next_api_changes/development/26621-ES.html

@dopplershift
Copy link
Member Author

@QuLogic Ah, I missed that.

@QuLogic
Copy link
Member

QuLogic commented Jun 3, 2024

Ping @dopplershift; I don't normally care about conda-forge packages, but some people have asked...

@QuLogic
Copy link
Member

QuLogic commented Jun 6, 2024

@conda-forge-admin please restart ci

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You're setting a constraint on the __osx virtual package directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@QuLogic
Copy link
Member

QuLogic commented Jun 6, 2024

ImportError: /home/conda/feedstock_root/build_artifacts/matplotlib-suite_1714079322516/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/matplotlib/_path.cpython-310-x86_64-linux-gnu.so: undefined symbol: _ZN3agg10curve3_div4initEdddddd

That looks real 😱

We reproduced this at the the Summit the other day, and I've opened conda-forge/ctng-compilers-feedstock#135 to get that fixed in the compilers.

@jakirkham
Copy link
Member

Based on discussion in the other thread, it looks like a configuration change is needed

Not entirely sure how the build choose the archiver, but one common way is checking what the environment variable AR is set to. So maybe something like this?

export AR="${BUILD_PREFIX}/bin/${HOST}-gcc-ar"

@rcomer rcomer mentioned this pull request Jun 7, 2024
3 tasks
@jakirkham
Copy link
Member

IIUC Meson is being used here. If so, it looks like it is possible to configure the ar used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants