Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lib{gcc,stdcxx}-ng to ignore_run_exports #20

Merged

Conversation

nehaljwani
Copy link
Member

Both are statically linked to micromamba:

$ ldd /path/to/micromamba
	linux-vdso.so.1 =>  (0x00007ffe7e544000)
	librt.so.1 => /lib64/librt.so.1 (0x00007f532fdcd000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f532fbc9000)
	libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f532f9af000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f532f792000)
	libm.so.6 => /lib64/libm.so.6 (0x00007f532f50e000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f532f17a000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f5330a99000)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Both are statically linked to micromamba:

$ ldd /path/to/micromamba
	linux-vdso.so.1 =>  (0x00007ffe7e544000)
	librt.so.1 => /lib64/librt.so.1 (0x00007f532fdcd000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f532fbc9000)
	libresolv.so.2 => /lib64/libresolv.so.2 (0x00007f532f9af000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f532f792000)
	libm.so.6 => /lib64/libm.so.6 (0x00007f532f50e000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f532f17a000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f5330a99000)
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@nehaljwani
Copy link
Member Author

Not sure what's going on with osx-arm64!

@isuruf
Copy link
Member

isuruf commented Oct 3, 2020

@conda-forge-admin, rerender

@nehaljwani
Copy link
Member Author

Hmm... so the conda-build version used by me was old. I wonder if conda-smithy should complain about it!

@nehaljwani
Copy link
Member Author

@conda-forge-admin restart ci

@nehaljwani
Copy link
Member Author

msys2/MSYS2-packages#2171 😢

@wolfv
Copy link
Member

wolfv commented Oct 6, 2020

Don't we need a similar thing for OS X? Happy to merge btw, and thnaks for the contribution!

@wolfv
Copy link
Member

wolfv commented Oct 6, 2020

ah, I was pretty confident that statically linking is working on OS X, too. I meant to ignore a potential run_exports from libstdcxx on OS X (or whatever the c++ stdlib on OS X is called, would have to look it up).

@isuruf
Copy link
Member

isuruf commented Oct 6, 2020

No need to statically link libc++.a. You can interchange system one and conda one as long as you don't do -D_LIBCPP_DISABLE_AVAILABILITY

@nehaljwani
Copy link
Member Author

That's true, but some day (I wish!), one will be using clang on all platforms instead of 3 different compilers for all platforms and would like to have a binary which doesn't link anything except glibc libs 😜 (on linux)

@wolfv
Copy link
Member

wolfv commented Oct 6, 2020

ah, good to know @isuruf. I was actually thinking of using this flag so that I can use the std::filesystem instead of our current polyfill ...

@wolfv wolfv merged commit 339501c into conda-forge:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants