ARM OSX Migrator #111
ARM OSX Migrator #111
Conversation
…nda-forge-pinning 2024.01.16.00.05.46
regro-cf-autotick-bot
requested review from
YarShev,
anmyachev,
devin-petersohn,
h-vetinari,
maksimbo1,
mvashishtha and
vnlitvinov
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-osx-arm64, some of jobs failed. Could you help us here to make CI green? |
recipe/meta.yaml
Outdated
| build: | ||
| - python # [build_platform != target_platform] | ||
| - cross-python_{{ target_platform }} # [build_platform != target_platform] |
There was a problem hiding this comment.
You need to move this section to modin-core, i.e. all outputs that have a script and a python dependency should have this block.
There was a problem hiding this comment.
Moved. One more question. Should we increase the build number? I guess we should have increased for unidist too.
There was a problem hiding this comment.
You can but it is not required as the original architectures don't change and the only packages where this change applies are the ones for the new architecture.
There was a problem hiding this comment.
I see. Some jobs are still failed and throw RuntimeError: SHA256 mismatch. Do you know the reason?
There was a problem hiding this comment.
This is happening for all jobs that build something. This means that the modin developer changed the release (tarball) retroactively.
There was a problem hiding this comment.
The problem is probably Ray specific and is not related to the changes in this PR.
There was a problem hiding this comment.
build on Windows started failing for some reason due to
OSError: [WinError 1455] The paging file is too small for this operation to complete. Do we put everything correctly in the meta.yml and around it?
This can happen when the build runs out of memory. It can (usually) be fixed by adding
azure:
settings_win:
variables:
SET_PAGEFILE: "True"
to conda-forge.yml and then rerendering.
There was a problem hiding this comment.
@h-vetinari, that is a good point. I will try in a separate PR. Do you know how much this configuration increases the pagefile size on Windows?
There was a problem hiding this comment.
It's set to 8GB. I had an unmerged PR to make this configurable, but I don't think we've ever needed something else than 8GB.
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
YarShev
force-pushed
the
bot-pr_arm_osx_h079f0a
branch
from
f44502e
to
12bd9ef
Compare
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
YarShev
force-pushed
the
bot-pr_arm_osx_h079f0a
branch
from
12bd9ef
to
2abe2ac
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| # TODO: Ray is failing on Windows when initializing, figure out the root cause. | ||
| # commands: | ||
| # - python -c "import modin.pandas as pd, modin.config as cfg; cfg.Engine.put('Ray'); df = pd.DataFrame([])" |
There was a problem hiding this comment.
You should figure out the root cause before merging, rather than unconditionally skipping tests (not even restricted to windows)...
There was a problem hiding this comment.
In general, I agree with you but I decided to go ahead and merge this PR because of the following.
- Test for Modin on Ray started failing regardless of the changes in this PR. I verified this in Check CI for Ray #112.
- We didn't modify the current builds for Modin but rather just added builds for the new architecture.
This feedstock is being rebuilt as part of the ARM OSX migration.
Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7539942352, please use this URL for debugging.