Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CROSS_F77_SIZEOF_LOGICAL #86

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Dec 19, 2023

missing env generated with perl maint/gen_cross.pl, as suggested in pmodels/mpich#5380 (comment)

I believe this closes #85, but I don't know how to add a test

generated with `perl maint/gen_cross.pl`
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@minrk minrk changed the title Missing cross logical Missing CROSS_F77_SIZEOF_LOGICAL Dec 19, 2023
@dalcinl
Copy link
Contributor

dalcinl commented Dec 19, 2023

The issue is related to cross-compiling, and in that case we cannot compile code and run a test to check that MPI_LOGICAL is not MPI_DATATYPE_NULL.

The only check I can imagine is to use grep and fail if the MPI_LOGICAL=MPI_DATATYPE_NULL string is in mpif.h, but I'm not really sure the extra work is worth it.

@minrk
Copy link
Member Author

minrk commented Dec 19, 2023

@dalcinl yeah, that's kind of what I was thinking.

conda-forge/mumps-feedstock#102 should show whether it worked, though not before merging.

@minrk minrk merged commit dd78ef2 into conda-forge:main Dec 20, 2023
12 checks passed
@minrk minrk deleted the missing-cross-logical branch December 20, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPI_LOGICAL is MPI_DATATYPE_NULL
2 participants