-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing int def header, fix install_name on mac, restore tests #102
Conversation
- fix default int size to 32 on Windows - actually run mpi tests
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thanks @minrk ! Should we mark as broken the previous Windows build with 64-bit index? Fortunately conda-forge/conda-forge-pinning-feedstock#5274 was not merged, so I think we do not have any package that built with 5.6.2 mumps packages. |
@traversaro yeah, that would probably be prudent |
not present by default on linux
linux mpich cross-compile builds are failing because of conda-forge/mpich-feedstock#86 linux openmpi builds are failing with:
which I don't understand. I don't get why CUDA anything is being loaded, which obviously won't work. |
cc @leofang (in case you have any ideas on the question above) |
recipe/mpiexec.sh
Outdated
@@ -7,6 +7,7 @@ if [[ "$mpi" == "mpich" ]]; then | |||
elif [[ "$mpi" == "openmpi" ]]; then | |||
export OMPI_MCA_plm=isolated | |||
export OMPI_MCA_rmaps_base_oversubscribe=yes | |||
export OMPI_MCA_btl=tcp,self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clueless here too. Just wondering: what happens if you set sm,self
instead?
@minrk @leofang The sm btl was available in v3, then they renamed it to vader in v4, and in v5 it is again named sm with vader as an alias scheduled for removal. Disclaimer: I'm not an Open MPI user, so I may have gotten any of these facts wrong. Regarding the weird CUDA failure, maybe the way to go is to add |
Yeah let's try that, though if it works then I don't know why the default we set (CUDA off) did not kick in. |
Co-authored-by: Joseph Capriotti <josephrcapriotti@gmail.com>
4eb6b30
to
ac850a0
Compare
disabling cuda works, but realized vader was never actually tested on its own. So running that test, then I think this is ready to go. If vader fails, I don't understand the implications of why cuda's being loaded here but apparently not in other openmpi runs. |
switch to vader seems to have fixed it. No idea why using tcp, which we've used for ages, triggers failure to load cuda. That's bizarre. |
closes #100
closes #103 because the install_name was wrong (revealed by the re-enabled tests)