Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v1.19.1 #14

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Update to v1.19.1 #14

merged 3 commits into from
Aug 27, 2022

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Aug 12, 2022

supersede #12

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xmnlab
Copy link
Member Author

xmnlab commented Aug 16, 2022

@conda-forge-admin, please rerender

@xmnlab xmnlab marked this pull request as ready for review August 16, 2022 02:38
@xmnlab xmnlab requested a review from scopatz as a code owner August 16, 2022 02:38
@xmnlab
Copy link
Member Author

xmnlab commented Aug 16, 2022

Hi @scopatz @conda-forge/help-c-cpp

the CI for osx is raising this error:


  "_gumbo_destroy_output", referenced from:
      _fz_parse_xml_from_html5 in libmupdf.a(xml.o)
ld: symbol(s) not found for architecture x86_64
Undefined symbols for architecture x86_64:
  "_gumbo_parse_with_options", referenced from:
clang: error: linker command failed with exit code 1 (use -v to see invocation)
      _fz_parse_xml_from_html5 in libmupdf.a(xml.o)
  "_gumbo_normalized_tagname", referenced from:
make: *** [Makefile:294: build/release/muraster] Error 1
make: *** Waiting for unfinished jobs....
      _xml_from_gumbo in libmupdf.a(xml.o)
  "_gumbo_destroy_output", referenced from:
      _fz_parse_xml_from_html5 in libmupdf.a(xml.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

do you have any idea?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [15]

@xmnlab
Copy link
Member Author

xmnlab commented Aug 16, 2022

Hi @scopatz @conda-forge/help-c-cpp

the CI for osx is raising this error:


  "_gumbo_destroy_output", referenced from:
      _fz_parse_xml_from_html5 in libmupdf.a(xml.o)
ld: symbol(s) not found for architecture x86_64
Undefined symbols for architecture x86_64:
  "_gumbo_parse_with_options", referenced from:
clang: error: linker command failed with exit code 1 (use -v to see invocation)
      _fz_parse_xml_from_html5 in libmupdf.a(xml.o)
  "_gumbo_normalized_tagname", referenced from:
make: *** [Makefile:294: build/release/muraster] Error 1
make: *** Waiting for unfinished jobs....
      _xml_from_gumbo in libmupdf.a(xml.o)
  "_gumbo_destroy_output", referenced from:
      _fz_parse_xml_from_html5 in libmupdf.a(xml.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

do you have any idea?

updating the patch for osx did the tricky .. now I am trying to fix other issues. nope to have it ready by tomorrow

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xmnlab
Copy link
Member Author

xmnlab commented Aug 23, 2022

now osx build is raising this error:

Error: Could not find libmupdf-third.dylib

but it doesn't make any sense because it should be there ... does anyone knows how to fix that?

@xmnlab
Copy link
Member Author

xmnlab commented Aug 23, 2022

in order to move forward for the maintenance of this package I am proposing to skip OSX build for now until we have someone to maintain that. I will open an issue for that.

@xmnlab xmnlab mentioned this pull request Aug 23, 2022
@xmnlab
Copy link
Member Author

xmnlab commented Aug 23, 2022

@scopatz https://github.com/orgs/conda-forge/teams/help-c-cpp

this PR is ready for review. thanks!

@xmnlab
Copy link
Member Author

xmnlab commented Aug 23, 2022

@conda-forge-admin, please rerender

@saraedum
Copy link
Member

In the osx build I only see these files being installed:

2022-08-16T20:47:30.8560040Z install -d $PREFIX/include/mupdf
2022-08-16T20:47:30.8641430Z install -d $PREFIX/include/mupdf/fitz
2022-08-16T20:47:30.8708370Z install -d $PREFIX/include/mupdf/pdf
2022-08-16T20:47:30.8774700Z install -m 644 include/mupdf/*.h $PREFIX/include/mupdf
2022-08-16T20:47:30.8847460Z install -m 644 include/mupdf/fitz/*.h $PREFIX/include/mupdf/fitz
2022-08-16T20:47:30.9247780Z install -m 644 include/mupdf/pdf/*.h $PREFIX/include/mupdf/pdf
2022-08-16T20:47:30.9450700Z install -d $PREFIX/lib
2022-08-16T20:47:30.9517840Z install -m 644 build/release/libmupdf.dylib $PREFIX/lib
2022-08-16T20:47:31.0221180Z install -d $PREFIX/bin
2022-08-16T20:47:31.0268290Z install -m 755  build/release/mutool build/release/muraster build/release/mupdf-gl $PREFIX/bin
2022-08-16T20:47:31.0322760Z install -d $PREFIX/share/man/man1
2022-08-16T20:47:31.0363920Z install -m 644 docs/man/*.1 $PREFIX/share/man/man1
2022-08-16T20:47:31.0493590Z install -d $PREFIX/share/doc/mupdf
2022-08-16T20:47:31.0594840Z # install -d $PREFIX/share/doc/mupdf/examples
2022-08-16T20:47:31.0697260Z install -m 644 README COPYING CHANGES $PREFIX/share/doc/mupdf
2022-08-16T20:47:31.0796950Z # install -m 644 docs/*.html docs/*.css docs/*.png $PREFIX/share/doc/mupdf
2022-08-16T20:47:31.0850560Z # install -m 644 docs/examples/* $PREFIX/share/doc/mupdf/examples

So, I don't see libmupdf-third.dylib being installed here.

@xmnlab
Copy link
Member Author

xmnlab commented Aug 24, 2022

thanks @saraedum ! appreciate that. I am trying again to fix the patch for osx

@xmnlab
Copy link
Member Author

xmnlab commented Aug 24, 2022

@saraedum now it is working :) thanks for your input! appreciate that!
this PR is ready for review :)

@xmnlab
Copy link
Member Author

xmnlab commented Aug 26, 2022

This PR is sitting here for 14 days. @conda-forge/core, is there someone that can help me?

@dopplershift
Copy link
Member

@xmnlab Can you add yourself as a maintainer in a separate PR following the documented method? Someone from core can merge that and then you can merge this.

@xmnlab
Copy link
Member Author

xmnlab commented Aug 26, 2022

sure thing! thanks @dopplershift , I will work on that now

@xmnlab
Copy link
Member Author

xmnlab commented Aug 26, 2022

@dopplershift , done: #21

@ocefpaf ocefpaf merged commit e0864a3 into conda-forge:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants