-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #14
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
disable python2.7! netgen has no support for python2.7 |
Also disable USE_GUI on Linux (like you have it on Windows already). |
@mhochsteger gui it is working for the current available linux-builds. I will disable it if it is too difficult to maintain. this are the current problems:
maybe @mingwandroid can give a short statement how to solve cmake-based builds which need the gl-headers which are located in sysroot/include/... |
You need to use a cmake toolchain file unfortunately. I am not at home and on a phone so I can't lookup a good reference, please clone AnacondaRecipes/aggregate and have a ripgrep for TOOLCHAIN. |
It would be awesome to add a feature to cmake so it queries the compiler as in something like CC -print-sysroot to avoid having to do this. |
Thanks, I found this one:
Solving this in a more elegant way would be really nice. But I have to admit that I don't understand the idea. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@mhochsteger @JSchoeberl osx: |
This happens when an extension module incorrectly links to the Python DSO. |
@mingwandroid The bindings are done with pybind11. No idea where linking is done incorrectly... |
Maybe this is related to the "evil hack" here: https://github.com/NGSolve/netgen/blob/master/libsrc/general/ngpython.hpp#L3 the references PR was merged yesterday. pybind/pybind11#1211 |
@looooo Thanks for the hint, I updated Netgen and removed the hack. Could you try building the latest version on master? |
As you may know, we are using pybind11 from conda-forge and therefor this commit is not yet included. I will try to find a way to use pybind11-master, but for sure this will need a few iterations to get done. Any help is appriciated. Also please have a look at: NGSolve/netgen#21 this is the branch I currently use in this PR. Maybe you can merge. |
after rerender linux fails with:
any ideas? otool for osx now produces this output:
To me this looks good. |
Also looking at the python3.7 build:
seems to be correct. So I don't think the error is because of mixed linked python versions. |
ok for linux it seems libGL is not part of the docker image anymore: conda-forge/docker-images@f598f6e |
I found this conversation: https://groups.google.com/a/continuum.io/forum/m/#!topic/anaconda/057P4uNWyCU So it seems dynamic linking to @rpath/libpython3.6m.dylib should be avoided? |
@conda-forge-admin, please rerender |
It is not good. I mentioned this already here: #14 (comment) . The python DSO should not be getting linked to. Our python interpreters are fully static now on Linux and macOS. |
@mingwandroid Sry, I think I misunderstood your comment. I patched the necessary parts with this: Not sure if this is the correct way. If you know of any better way how to handle this in a cmake-library please let me know. |
Do I understand correctly, that libraries providing Python bindings should NOT link at all to libpython? (with Conda on Linux and MacOS) |
That is correct. |
@looooo your patch looks OK, but you should not be seeing |
It is likely this feedstock needs to be rebuilt.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
smesh
freecad
And potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one.This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!