Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networkx 3.3 doesn't support Python 3.9 anymore #57

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

danielbrown2
Copy link
Contributor

@danielbrown2 danielbrown2 commented Apr 6, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Networkx 3.3 dropped Python 3.9 networkx/networkx#7028

The recipe for this feedstock hasn't been updated properly though: https://github.com/conda-forge/networkx-feedstock/blob/main/recipe/meta.yaml#L18

Update to python 3.10 minimum for Networkx 3.3
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@h-vetinari
Copy link
Member

FWIW, we need to fix the repodata anyway (because build _0 would still remain "compatible" with 3.9, according to the metadata), see conda-forge/conda-forge-repodata-patches-feedstock#697. This PR should still be merged because we need the updated lower bounds going forward.

@RMeli
Copy link
Member

RMeli commented Apr 7, 2024

Thanks! I just bumped into this issue too.

@RMeli
Copy link
Member

RMeli commented Apr 7, 2024

This has been an issue for the previous release as well, see #52 and networkx/networkx#7039. Is there a way to put some checks in place?

@h-vetinari
Copy link
Member

This has been an issue for the previous release as well, see #52 and networkx/networkx#7039. Is there a way to put some checks in place?

Not easy to do with the current setup; we'd need to build it once and test it against several python versions, which conda-build doesn't support.

@h-vetinari
Copy link
Member

It's basically up to the maintainers to be careful about this and check what upstream is doing, before pressing merge just because the CI is green.

@h-vetinari
Copy link
Member

Now that conda-forge/conda-forge-repodata-patches-feedstock#697 fixed this, let's put this in so we have a release-able state on main again.

@h-vetinari h-vetinari merged commit 9701a0c into conda-forge:main Apr 8, 2024
3 checks passed
@RMeli
Copy link
Member

RMeli commented Apr 8, 2024

which conda-build doesn't support

I see, thank you for the clarification.

@MridulS
Copy link
Member

MridulS commented Apr 8, 2024

It's basically up to the maintainers to be careful about this and check what upstream is doing, before pressing merge just because the CI is green.

Urghh my bad. Thanks for taking care of this everyone!!

@MridulS
Copy link
Member

MridulS commented Apr 8, 2024

Also fwiw, I should also have updated the constrained deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants