-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networkx 3.3 doesn't support Python 3.9 anymore #57
Conversation
Update to python 3.10 minimum for Networkx 3.3
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
FWIW, we need to fix the repodata anyway (because build |
Thanks! I just bumped into this issue too. |
This has been an issue for the previous release as well, see #52 and networkx/networkx#7039. Is there a way to put some checks in place? |
Not easy to do with the current setup; we'd need to build it once and test it against several python versions, which conda-build doesn't support. |
It's basically up to the maintainers to be careful about this and check what upstream is doing, before pressing merge just because the CI is green. |
Now that conda-forge/conda-forge-repodata-patches-feedstock#697 fixed this, let's put this in so we have a release-able state on |
I see, thank you for the clarification. |
Urghh my bad. Thanks for taking care of this everyone!! |
Also fwiw, I should also have updated the constrained deps. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Networkx 3.3 dropped Python 3.9 networkx/networkx#7028
The recipe for this feedstock hasn't been updated properly though: https://github.com/conda-forge/networkx-feedstock/blob/main/recipe/meta.yaml#L18