Drop Python 3.9 support #7028
Merged
Drop Python 3.9 support #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodmillman
commented
Oct 19, 2023
stefanv
approved these changes
Oct 19, 2023
dschult
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
This looks good to me.
I looked at the changes in Python 3.10 to see what we could now use and noticed:
- the
matchstatement which is a super-powerful switch/case system. - the
|operator acts with classes now (as this PR implements). The result is like a tuple combining classes in e.g.isinstance(obj, class1 | class2) itertools.pairwiseis now available (probably making our utilitypairwiseobsolete, but I haven't checked the details yet.
I'll make an issue to check whether we can/should change code due to any of these.
I also notice type annotations have been corrected in networkx/readwrite/text.py. They must have slipped into that module. I'll prepare a PR to remove those.
3 tasks
dschult
pushed a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
* Drop Python 3.9 support See https://scientific-python.org/specs/spec-0000/ * Run ruff linter
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 26, 2023
* Drop Python 3.9 support See https://scientific-python.org/specs/spec-0000/ * Run ruff linter
Closed
5 tasks
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* Drop Python 3.9 support See https://scientific-python.org/specs/spec-0000/ * Run ruff linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://scientific-python.org/specs/spec-0000/