-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs v11.0.0 #53
nodejs v11.0.0 #53
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
command failing with a syntax error has both `-std=gnu++1y` from node and `-std=c++17` from conda-build, so a conflict there is my first guess.
Compiler failure on linux was due to |
maybe this saves enough time
@@ -1,5 +1,7 @@ | |||
#!/usr/bin/env bash | |||
|
|||
# remove `-std=c++17` from CXXFLAGS | |||
export CXXFLAGS=$(echo $CXXFLAGS | sed -E 's@\-std=[^ ]+@@') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this what you are trying to do here?
export CXXFLAGS=${CXXFLAGS/-std=c++17/} # remove
or
export CXXFLAGS=${CXXFLAGS/-std=c++17/-std=c++14} # rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I didn't know about that! I want to make sure it gets removed and is insensitive to the right hand side, so if it gets updated, this doesn't change. Can the ${foo//}
replacement take expressions or wildcards? If not, then this code is doing what it means to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the
${foo//}
replacement take expressions or wildcards?
Yeah, I think so.
You can remove ltcg, which enables link time code optimization, this will use less resources, but incur a small runtime performance penalty. https://github.com/nodejs/node/blob/master/vcbuild.bat#L169 |
I discovered that removing ltcg greatly increases build time, not decreases. Or, at least the build didn't get nearly as far before timing out with that disabled. |
It is very likely that the current package version for this feedstock is out of date.
Notes and instructions for merging this PR:
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one.This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable.Finally, feel free to drop us a line if there are any issues!