-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine CONDA_ENV_SYSROOT from environment #31
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
@jakirkham I think you should review this as I know you had opinions regarding how we detect the sysroot. |
Thanks for the work here. Sorry for the delay. Am a bit slammed ATM. So likely won't have time to look until some time midweek next week. Sorry again for the delay. |
The recent @isuruf @jakirkham , please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, but would defer to @jakirkham here as he had the most opinions about the sysroot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now with PR ( conda-forge/ctng-compiler-activation-feedstock#9 ) in and the updates here, this LGTM.
Thanks @pearu! 😄 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)See discussions in:
https://github.com/conda-forge/staged-recipes/pull/9225/files#r330386001