Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine CONDA_ENV_SYSROOT from environment #31

Merged
merged 5 commits into from
Nov 18, 2019

Conversation

pearu
Copy link
Contributor

@pearu pearu commented Nov 3, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See discussions in:
https://github.com/conda-forge/staged-recipes/pull/9225/files#r330386001

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pearu
Copy link
Contributor Author

pearu commented Nov 3, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

recipe/install_nvcc.sh Outdated Show resolved Hide resolved
recipe/install_nvcc.sh Outdated Show resolved Hide resolved
@pearu pearu changed the title Determine CONDA_ENV_SYSROOT from environment [WIP] Determine CONDA_ENV_SYSROOT from environment Nov 3, 2019
@kkraus14
Copy link
Contributor

kkraus14 commented Nov 4, 2019

@jakirkham I think you should review this as I know you had opinions regarding how we detect the sysroot.

@jakirkham
Copy link
Member

Thanks for the work here. Sorry for the delay. Am a bit slammed ATM. So likely won't have time to look until some time midweek next week. Sorry again for the delay.

@pearu
Copy link
Contributor Author

pearu commented Nov 15, 2019

The recent gcc_linux-64 provides CONDA_BUILD_SYSROOT (PR conda-forge/ctng-compiler-activation-feedstock#9), so we don't need to determine CONDA_ENV_SYSROOT in the nvcc installation script anymore.

@isuruf @jakirkham , please review.

@pearu pearu requested a review from isuruf November 15, 2019 09:51
Copy link
Contributor

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but would defer to @jakirkham here as he had the most opinions about the sysroot

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now with PR ( conda-forge/ctng-compiler-activation-feedstock#9 ) in and the updates here, this LGTM.

@jakirkham jakirkham merged commit 4712ce1 into conda-forge:master Nov 18, 2019
@jakirkham
Copy link
Member

Thanks @pearu! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants