Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX Migrator #3

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/674042892, please use this URL for debugging

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy
Copy link
Member

xhochy commented Mar 23, 2021

@vpirogov The build error I get here is the same when I also build Google JAX on Apache ARM64. It is present in the latest 2.1 releases as well as the 2.2-rc but is fixed on master of oneDNN. Just using the patch that updated xbyak_aarch64 leads to a lot of patch mismatch errors. Any chance to see these fixes in a release of oneDNN soon?

../src/cpu/aarch64/xbyak_aarch64/xbyak_aarch64_util.h:20:10: fatal error: 'sys/prctl.h' file not found
#include <sys/prctl.h>
         ^~~~~~~~~~~~~
1 error generated.

@igorsafo
Copy link
Member

@vpirogov The build error I get here is the same when I also build Google JAX on Apache ARM64. It is present in the latest 2.1 releases as well as the 2.2-rc but is fixed on master of oneDNN. Just using the patch that updated xbyak_aarch64 leads to a lot of patch mismatch errors. Any chance to see these fixes in a release of oneDNN soon?

../src/cpu/aarch64/xbyak_aarch64/xbyak_aarch64_util.h:20:10: fatal error: 'sys/prctl.h' file not found
#include <sys/prctl.h>
         ^~~~~~~~~~~~~
1 error generated.

Hi @xhochy ,
I will take a look at the issue.

Regards,
Igor Safonov

@igorsafo
Copy link
Member

Hi @xhochy ,
The issue was fixed in the following PR: oneapi-src/oneDNN#1001
@kawakami-k will work on backporting the fix into v2.1 and v2.2 releases.

Regards,
Igor Safonov

@vpirogov
Copy link

The fix is backported to rls-v2.1 and rls-v2.2 branches in oneDNN repo.

@igorsafo
Copy link
Member

The fix is backported to rls-v2.1 and rls-v2.2 branches in oneDNN repo.

@vpirogov The build system is based on release version. We need to make oneDNN v2.1.3 release and switch onto that version in recipe/meta.yaml

@igorsafo
Copy link
Member

igorsafo commented Apr 1, 2021

@conda-forge-admin, please restart ci

@xhochy xhochy added the bot-rerun Instruct the bot to retry the PR label Apr 1, 2021
@xhochy
Copy link
Member

xhochy commented Apr 1, 2021

@igorsafo Once a new version is released, we better add the bot-rerun label to the PRs created by the bot. The bot will then recreate these PRs on top of master again. I'm amazed though that the build passes in CI but fails locally.

@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/707460606

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arm_osx_hb331f0 branch April 1, 2021 05:46
@igorsafo
Copy link
Member

igorsafo commented Apr 1, 2021

@xhochy I see, thank you for the explanation! BTW, what is the idea behind recreating PR for the case when target branch is updated? This behavior complicates tracking of the issue, since each time we should update links to the original issue.

@igorsafo
Copy link
Member

igorsafo commented Apr 1, 2021

@xhochy Could you please provide a reproducer for build fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants