Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parcels v2.4.2 #95

Merged
merged 11 commits into from
Jun 7, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found in the meta.yaml but not found by source code inspection:

  • pymbolic
  • pytest

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5191585871, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Comment on lines -56 to -57
- parcels.scripts
- parcels.tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like parcels.scripts.get_examples was removed but it is still imported when importing these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. It is the entrypoint that needs updating.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it; will fix this today

recipe/meta.yaml Outdated
script:
- {{ PYTHON }} setup.py bdist_wheel --dist-dir=dist
- {{ PYTHON }} -m pip install --find-links=dist --no-deps --ignore-installed --no-cache-dir -vvv {{ name }}
entry_points:
- parcels_get_examples = parcels.scripts.get_examples:main
- parcels_convert_npydir_to_netcdf = parcels.scripts.convert_npydir_to_netcdf:main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is declared in the metadata but it doesn't seem to exist. is that correct @conda-forge/parcels team? Should we remove it?

Updating to new location of parcels CD-files
Updating sha256
updating test to 'normal' python call
Using wget for example_peninsula script directly from parcels repo
Adding wget to dependencies (for downloading the peninsula_example file)
Using curl to download example_peninsula script
@erikvansebille
Copy link
Contributor

I've now got green ticks on all CI except for the Travis CI. Do you know if this is a problem, @ocefpaf? If not, can I merge? if so, how can I fix this?

@ocefpaf
Copy link
Member

ocefpaf commented Jun 7, 2023

I've now got green ticks on all CI except for the Travis CI. Do you know if this is a problem, @ocefpaf? If not, can I merge? if so, how can I fix this?

We are using Travis-CI for aarch and ppcle here. We can:

  1. ignore those platforms and merge
  2. try to use cross compilation for those platforms

However a deeper question is: parcels per se should be noarch, maybe we could do a parcels-core, noarch package, and a parcels package that depends on noarch parcels-core but adds the optional compilers. I say this b/c some folks may want to use their system compilers and download parcels-core only. That would make the builds here faster and would improve the user experience for those who do not want to use conda-forge compilers. Does that make sense do you?

@erikvansebille
Copy link
Contributor

Thanks for the quick response, @ocefpaf. I'll then merge this so that v2.4.2 gets onto the conda-forge channel.

As for your suggestion to split into a parcels-core and parcels: I don't yet oversee what this would entail at our end. @willirath has helped us set up this conda-forge repo; he may have more ideas about how this could be done and what the (dis)advantages are

@erikvansebille erikvansebille merged commit 1642224 into conda-forge:main Jun 7, 2023
18 of 19 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 2.4.2_h84265a branch June 7, 2023 13:08
@ocefpaf
Copy link
Member

ocefpaf commented Jun 7, 2023

I don't yet oversee what this would entail at our end. @willirath has helped us set up this conda-forge repo; he may have more ideas about how this could be done and what the (dis)advantages are

In a way, folks who choose to install parcels won't see any change but we would give an extra option to others who may wish to install parcels-core. That would be a similar experience to what users get from PyPI. Note that, making a multiple output recipes is a bit annoying and error prone. I would do that myself or guide someone all the way. I'm not asking your this team to do that!

PS: I'll look into cross compilation to see if we can get aarch and ppc in the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants