-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parcels v2.4.2 #95
parcels v2.4.2 #95
Conversation
…nda-forge-pinning 2023.06.06.09.57.57
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- parcels.scripts | ||
- parcels.tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like parcels.scripts.get_examples
was removed but it is still imported when importing these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. It is the entrypoint that needs updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on it; will fix this today
recipe/meta.yaml
Outdated
script: | ||
- {{ PYTHON }} setup.py bdist_wheel --dist-dir=dist | ||
- {{ PYTHON }} -m pip install --find-links=dist --no-deps --ignore-installed --no-cache-dir -vvv {{ name }} | ||
entry_points: | ||
- parcels_get_examples = parcels.scripts.get_examples:main | ||
- parcels_convert_npydir_to_netcdf = parcels.scripts.convert_npydir_to_netcdf:main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is declared in the metadata but it doesn't seem to exist. is that correct @conda-forge/parcels team? Should we remove it?
Updating to new location of parcels CD-files
Updating sha256
updating test to 'normal' python call
Using wget for example_peninsula script directly from parcels repo
Adding wget to dependencies (for downloading the peninsula_example file)
Using curl to download example_peninsula script
I've now got green ticks on all CI except for the Travis CI. Do you know if this is a problem, @ocefpaf? If not, can I merge? if so, how can I fix this? |
We are using Travis-CI for aarch and ppcle here. We can:
However a deeper question is: parcels per se should be noarch, maybe we could do a |
Thanks for the quick response, @ocefpaf. I'll then merge this so that v2.4.2 gets onto the conda-forge channel. As for your suggestion to split into a |
In a way, folks who choose to install PS: I'll look into cross compilation to see if we can get aarch and ppc in the next PR. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found in the meta.yaml but not found by source code inspection:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5191585871, please use this URL for debugging.