Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild with Jpeg not turbo #134

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Feb 1, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with going back to vanilla jpeg until we have a better solution, but I'd like to have @ocefpaf's input here as well (since he chose to merge libjpeg-turbo intentionally)

@ocefpaf
Copy link
Member

ocefpaf commented Feb 3, 2023

I'm fine with going back to vanilla jpeg until we have a better solution, but I'd like to have @ocefpaf's input here as well (since he chose to merge libjpeg-turbo intentionally)

Indeed. I kind of wanted to force our hand to move to turbo. But, to be honest, I won't have time until March to do that is required (proper migration, etc). TL;DR I'm OK reverting and re-visiting this when I have some free time.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Feb 4, 2023

Ok, lets hear the plan out, but I don't think this is the right way to go about it with only a single PR.

i'm sadly reminding of my previous attempt, almost 3 years ago. conda-forge/conda-forge-pinning-feedstock#378

@hmaarrfk hmaarrfk merged commit c76aa8f into conda-forge:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants