-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: poetry v1.2 #57
Comments
@aryarm, for my own work, it turned out that the alpha version of potery-core was sufficient, see: I am happy to create a dev branch of poetry, but it relies on development versions of other packages (poetry-core and cleo), so it's substantially more effort than just making a development version of this one package: I just want to make sure it's worth the effort. |
I'm going to go ahead and work on this. Here's the checklist:
|
Hi @xylar, On my end, this isn't a super important request. After all, I can always just use the standard install script instead of installing from conda-forge. But it would certainly be nice to be able to isolate my poetry installation in a conda environment. I'm elated that you're taking up the mantle on this, but no need to put too much work into it if it's really difficult. |
I mostly wanted to be sure that you need poetry and not just poetry core. It sounds like the answer is, yes you do. It's not a ton of work. I just dropped it earlier because it turned out I didn't need it myself. |
I've been very eager to get PEP 660 support which has been sitting in the main branch of poetry-core for what seems like ages. ...hmm, but thinking this through, i think it's only really useful for that purpose if it's on PyPI. |
@maresb, I think that feature will likely still be useful on |
Ah, good point! Yes, it would be very interesting to try out. To be specific, the experiment is to do an editable install with the following pyproject.toml [build-system]
requires = ["poetry-core>1.0.7"]
build-backend = "poetry.core.masonry.api" which should fail without an existing install given that the latest PyPI version is 1.0.7. |
@maresb, that experiment you can already do. You need to install the development version of
or include this channel in creating your development environment. You don't need the full |
Hmm, I must say that I really don't understand poetry-core's versioning conventions... The current stable release is But @aryarm was referring to a mysterious So I'm not sure what to expect. Is the next release going to be |
@maresb, I think you're confusing |
And, yes, |
@aryarm, hmm, this is a fair amount of work. Good thing I'm a sucker for the sunken cost fallacy. I've put too much effort in now to abandon this thing... ;-) |
In earnest, though, these kinds of projects are always good exercises. I needed a reminder how to make use of multiple dev. packages at once. And |
@xylar, you have my glowing admiration! I appreciate you so much :D I hope you know that your efforts are also pretty inspiring to students like me. I think I'd like to learn how to contribute to feedstocks myself, now. And thanks for outlining things in that checklist - that really helps me keep track and understand what you've been up to |
I would be happy to help you get started if you have software of your own you'd like to create a recipe for, or if there's software not yet on conda-forge you'd like to add. |
@aryarm, this should be available by tomorrow. To install it, you need to include the channels
Let me know how that goes. |
Closed via #58 |
Thank you very much @xylar! Because of this build I'm now able to use the CLI flags from Poetry v1.2 within my Conda environments. I really appreciate your work on this. |
Hi all,
First, thank you for creating this feedstock! It's been very helpful.
Having the ability to install v1.2 would be helpful for my own projects. I'd like to inquire as to the possibility of building it, perhaps with a separate label or branch as described in #56 (comment). Is this possible and what would it involve?
I've never contributed to a cf feedstock before, but if needed, I might be able to offer some help.
The text was updated successfully, but these errors were encountered: