Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @xylar as a maintainer #69

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Add @xylar as a maintainer #69

merged 4 commits into from
Jan 26, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Jan 26, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xylar
Copy link
Contributor Author

xylar commented Jan 26, 2022

@conda-forge-admin, please rerender

@xylar
Copy link
Contributor Author

xylar commented Jan 26, 2022

@kalefranz and @mingwandroid, it doesn't look like the autobot is doing the trick here anymore. If you're willing to have me as a maintainer, I'd be willing to help get things working again.

I also need a build of 20.4.3 or 20.4.4 with python 3.10 to get the following PR in: conda-forge/poetry-feedstock#58. I'll create a temporary branch for that work, assuming you're okay with it.

@@ -1,4 +1,3 @@
bot: {automerge: true}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing the automerge bot because I think that's causing trouble and dependencies aren't getting updated when they need to. In my view, the bot is only useful for packages that have fixed dependencies without constraints that could change with time. pip check will not notice that constraints are being violated unless an out-of-range version actually gets installed during testing, which is often not the case.

@xylar
Copy link
Contributor Author

xylar commented Jan 26, 2022

@conda-forge/core, this feedstock seems to have been left to the bots and neither of the maintainers has had any activity on GitHub for many months. Would one of you be willing to merge this so I can take over?

@isuruf isuruf merged commit dfffd38 into conda-forge:master Jan 26, 2022
@xylar
Copy link
Contributor Author

xylar commented Jan 26, 2022

Thanks @isuruf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants