Skip to content
This repository has been archived by the owner on Aug 16, 2019. It is now read-only.

rename to pre-commit #35

Closed
lewisacidic opened this issue Aug 14, 2019 · 6 comments
Closed

rename to pre-commit #35

lewisacidic opened this issue Aug 14, 2019 · 6 comments

Comments

@lewisacidic
Copy link

lewisacidic commented Aug 14, 2019

The package name pre_commit (with underscore) is different to the project name pre-commit (with hyphen) used on:

This makes the conda-forge package harder to find, more likely to enter incorrectly.

I propose the package be renamed. The procedure for renaming is detailed here

@xmnlab
Copy link
Member

xmnlab commented Aug 14, 2019

+1

nicoddemus added a commit to nicoddemus/staged-recipes that referenced this issue Aug 14, 2019
Copied verbatim from conda-forge/pre_commit, only changing
the package name.

See conda-forge/pre_commit-feedstock#35
nicoddemus added a commit to nicoddemus/staged-recipes that referenced this issue Aug 14, 2019
Copied verbatim from conda-forge/pre_commit, only changing
the package name.

See conda-forge/pre_commit-feedstock#35
nicoddemus added a commit to nicoddemus/staged-recipes that referenced this issue Aug 14, 2019
Copied verbatim from conda-forge/pre_commit, only changing
the package name and build number.

See conda-forge/pre_commit-feedstock#35
nicoddemus added a commit to nicoddemus/staged-recipes that referenced this issue Aug 14, 2019
Copied almost verbatim from conda-forge/pre_commit, only changing:

* package name
* build number
* pip install command

See conda-forge/pre_commit-feedstock#35
@nicoddemus
Copy link
Member

Done, thanks for the pointer:

conda-forge/staged-recipes#9143

nicoddemus added a commit to nicoddemus/staged-recipes that referenced this issue Aug 14, 2019
Copied almost verbatim from conda-forge/pre_commit, only changing:

* package name
* build number
* pip install command

See conda-forge/pre_commit-feedstock#35
@lewisacidic
Copy link
Author

Great, thanks for the speedy action! Should I close the issue?

@asottile
Copy link

when ready, please update the docs -- thanks!

@nicoddemus
Copy link
Member

Great, thanks for the speedy action! Should I close the issue?

Let's wait until the repository is up and ready. 😁

nicoddemus added a commit to nicoddemus/pre-commit.github.io that referenced this issue Aug 15, 2019
@nicoddemus
Copy link
Member

New repo is up:

https://github.com/conda-forge/pre-commit-feedstock

Docs PR: pre-commit/pre-commit.com#258

Thanks everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants