Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to build with CUDA 11.7. #10

Merged
merged 6 commits into from
May 30, 2022
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 27, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Rebuilding to allow __cuda pinning to match the recently released CUDA 11.7. I also added myself to the recipe maintainers, if that's alright with you @prashantkhoje!

cc: @quasiben @gmarkall

@bdice bdice requested a review from prashantkhoje as a code owner May 27, 2022 00:47
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented May 27, 2022

@conda-forge-admin, please rerender

recipe/meta.yaml Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented May 27, 2022

@conda-forge-admin, please rerender

@gmarkall
Copy link
Contributor

We'd talked before about removing the upper bound on the __cuda runtime constraint here:

- __cuda >={{ cuda_major ~ ".0" }},<={{ cuda_compiler_version }}

Does that need doing for this PR too?

@prashantkhoje
Copy link
Contributor

If builds with 11.x can run in any 11.x environment, i agree we can remove upper bound.

I wonder why the build failed to run for ppc64le python 3.9.

@bdice
Copy link
Contributor Author

bdice commented May 27, 2022

We'd talked before about removing the upper bound on the __cuda runtime constraint here:

- __cuda >={{ cuda_major ~ ".0" }},<={{ cuda_compiler_version }}

Does that need doing for this PR too?

I wasn't 100% sure if you wanted to do that or not. I will remove it.

@prashantkhoje prashantkhoje merged commit 363186e into conda-forge:main May 30, 2022
@prashantkhoje
Copy link
Contributor

Thank you for the contribution.

@jakirkham
Copy link
Member

Thanks Prashant! 🙏

@bdice
Copy link
Contributor Author

bdice commented May 31, 2022

Yes, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants