Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Enable Python 3.6 #9

Merged
merged 4 commits into from
May 29, 2017
Merged

Enable Python 3.6 #9

merged 4 commits into from
May 29, 2017

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented May 29, 2017

Fixes #5
Closes #3

  • Enables Python 3.6 builds of pycrypto.
  • Adds a hack to pick up the MSVC provided stdint.h if available.

Inspired by this suggestion.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

If the MSVC version used has `stdint.h` (namely VS 2015+), then force
use of the MSVC provided `stdint.h` instead of using the stand-in copy
of `stdint.h` provided by `pycrypto`. This should fix some build issues
encountered with Python 3.6 and allow for a more proper build on Python
3.5 when using MSVC.
script:
- export LDFLAGS="-headerpad_max_install_names" # [osx]
- set CL=/FI"%VCINSTALLDIR%\\INCLUDE\\stdint.h" %CL% # [win and py>=35]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces a particular copy of stdint.h to be used by all #include directives in the C code. Should note this overrides the stdint.h that PyCrypto provides.

@jakirkham jakirkham merged commit 89fedf5 into conda-forge:master May 29, 2017
@jakirkham jakirkham deleted the enable_win_py36 branch May 29, 2017 21:17
@jakirkham
Copy link
Member Author

cc @lexual

@jakirkham jakirkham mentioned this pull request May 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants