Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Python 3.6 on Windows #5

Closed
jakirkham opened this issue Mar 7, 2017 · 4 comments
Closed

Python 3.6 on Windows #5

jakirkham opened this issue Mar 7, 2017 · 4 comments

Comments

@jakirkham
Copy link
Member

jakirkham commented Mar 7, 2017

This library fails to build on Windows Python 3.6.

Edit: Strangely this happens using the same VC version.

xref: pycrypto/pycrypto#216
xref: pycrypto/pycrypto#218
ref: https://ci.appveyor.com/project/conda-forge/pycrypto-feedstock/build/1.0.6

@jakirkham
Copy link
Member Author

jakirkham commented Mar 7, 2017

Probably this suggested change might fix it.

Edit: This doesn't really seem feasible.

@jakirkham
Copy link
Member Author

Probably the best strategy would be to backport a relevant patch from pycryptodome. Though figuring out what patch would likely be a pain.

@jakirkham
Copy link
Member Author

Would also note that pycrypto ships its own stdint.h for only Windows VC versions. Am guessing this is somehow clobbering the system copy. Either we need to guard against this by using it with a guard like #if defined(_MSC_VER) && _MSC_VER < 1400 or we need to add some missing pieces to it. The latter sounds volatile. IMHO we should do the former.

ref: https://msdn.microsoft.com/en-us/library/b0084kay.aspx

@jakirkham
Copy link
Member Author

Fixed by PR ( #9 ).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant