pyorc v0.8.0 #33

regro-cf-autotick-bot · 2022-11-19T15:55:54Z

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Dependencies have been updated if changed: see upstream
Tests have passed
Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

pybind11

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3504080213, please use this URL for debugging.}

Closes #30
Closes #31

…nda-forge-pinning 2022.11.19.13.25.46

conda-forge-linter · 2022-11-19T15:55:59Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

galipremsagar · 2022-12-05T04:29:24Z

@conda-forge-linter rerender

…nda-forge-pinning 2022.12.04.19.22.35

github-actions · 2022-12-05T04:30:38Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyorc-feedstock/actions/runs/3616949097.

github-actions · 2022-12-05T04:31:01Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyorc-feedstock/actions/runs/3616949516.

jakirkham · 2022-12-07T09:41:31Z

@noirello, think this is trying to build the ORC library as part of the Python build instead of using the libraries from the orc package already supplied. Is there a way to change the build process so pyorc uses the libraries from orc?

Edit: Actually think it is these libraries getting linked to the extension module. We can skip those when ORC is already built IIUC.

jakirkham · 2022-12-07T19:09:13Z

recipe/meta.yaml


 build:
  number: 0
-  script: PYORC_SKIP_ORC_BUILD=1 {{ PYTHON }} -m pip install . -vv
+  script: PYORC_SKIP_ORC_BUILD=1 PYORC_LIBRARIES="orc" {{ PYTHON }} -m pip install . -vv


Since we only need to link to orc when ORC is prebuilt (as is the case here), we just override the libraries linked to, which seems to resolve the build issue seen previously on CI (attached log for posterity)

jakirkham · 2022-12-07T19:12:15Z

Looks like we are now seeing a segfault during testing on CI (also attached log for posterity).

noirello · 2022-12-07T19:47:47Z

@jakirkham Thank you for driving this. There are a couple things that made the conda-forge build difficult and I hadn't got the time to look into it thoroughly.

One of the reason this build is breaking, that the zlib library somehow went AWOL on the linux cpython builds since this PR, and no longer possible to link to the module. The zlib package is listed in the list of conda dependencies, I had no issues linking it previously, I don't know what happened there.

While looking a little bit into it, turned out that it's unnecessary to link the zlib library to the module. That's why I added the extra env var config recently, but linking only the orc library isn't enough (or at least to the non-conda version of the module which builds the ORC lib itself). For example the protobuf symbols are missing from the module's .so file during test. I'm quite confused which symbols are statically included in the orc library and which are not.

The segfault issue is related to ORC-1288, fixed in the recently released ORC 1.8.1, so we have to wait on that conda release.

jakirkham · 2022-12-07T21:02:03Z

Ah ok. Thanks for all the context! 🙏

With zlib, a libzlib shared library was split out ( conda-forge/zlib-feedstock#52 ). Though this happened a while ago. Not sure why the impact to this feedstock was so delayed.

Though as you say, these libraries shouldn't be needed here.

Interesting would be curious to know what the protobuf issue was. Do you have a reproducer? In any event, doesn't seem to be coming up for the feedstock so far.

Yeah looks like the orc update 1.8.1 just got added with PR ( conda-forge/orc-feedstock#52 ). Asking for a review there. This is now merged and packages are up.

Also we may need a migrator given the tight orc pinning. Though the bot should open a migrator ~~once orc version 1.8.1 is packaged~~ soon.

Anyways hopefully we should get this unstuck soon.

galipremsagar · 2022-12-09T01:18:42Z

@conda-forge-linter rerender

github-actions · 2022-12-09T01:20:18Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyorc-feedstock/actions/runs/3653566430.

jakirkham · 2022-12-09T01:47:14Z

Think we need an orc 1.8.1 migrator ( like PR conda-forge/conda-forge-pinning-feedstock#3373 ) to proceed

kkraus14 · 2022-12-09T02:43:23Z

Think we need an orc 1.8.1 migrator ( like PR conda-forge/conda-forge-pinning-feedstock#3373 ) to proceed

Any idea why the bot hasn't opened the PR?

jakirkham · 2022-12-09T03:08:06Z

Not sure. Would suggest raising an issue here

jakirkham · 2022-12-09T21:11:12Z

Raised here ( regro/cf-scripts#1576 )

jakirkham · 2022-12-10T21:22:21Z

Here's the migrator ( conda-forge/conda-forge-pinning-feedstock#3829 )

noirello · 2022-12-11T12:21:21Z

@conda-forge-linter rerender

github-actions · 2022-12-11T12:22:43Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyorc-feedstock/actions/runs/3668927072.

noirello · 2022-12-12T14:58:41Z

Shouldn't have the linter updated the ORC version?

kkraus14 · 2022-12-12T17:38:20Z

Needs the migrator from this PR: #34

…nda-forge-pinning 2022.12.12.15.21.25

kkraus14 · 2022-12-12T17:59:41Z

This should be good to go!

noirello

Thank you guys for all the help!

jakirkham · 2022-12-12T19:29:36Z

Thank you! 🙏

regro-cf-autotick-bot added 2 commits November 19, 2022 15:55

updated v0.8.0

cf81808

MNT: Re-rendered with conda-build 3.23.1, conda-smithy 3.22.0, and co…

d932148

…nda-forge-pinning 2022.11.19.13.25.46

regro-cf-autotick-bot requested a review from noirello as a code owner November 19, 2022 15:55

MNT: Re-rendered with conda-build 3.23.2, conda-smithy 3.22.0, and co…

330fd73

…nda-forge-pinning 2022.12.04.19.22.35

Try just linking orc

aa0ee63

jakirkham reviewed Dec 7, 2022

View reviewed changes

kkraus14 mentioned this pull request Dec 8, 2022

Update protobuf to 4.21 and arrow to 10 rapidsai/integration#577

Merged

MNT: Re-rendered with conda-build 3.23.3, conda-smithy 3.22.1, and co…

8afb6ee

…nda-forge-pinning 2022.12.12.15.21.25

kkraus14 approved these changes Dec 12, 2022

View reviewed changes

noirello approved these changes Dec 12, 2022

View reviewed changes

noirello merged commit 28177b0 into conda-forge:main Dec 12, 2022

kkraus14 mentioned this pull request Dec 12, 2022

Rebuild for orc181 #34

Closed

regro-cf-autotick-bot deleted the 0.8.0_hbb1e9c branch December 12, 2022 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pyorc v0.8.0 #33

pyorc v0.8.0 #33

regro-cf-autotick-bot commented Nov 19, 2022 •

edited by jakirkham

Loading

conda-forge-linter commented Nov 19, 2022

galipremsagar commented Dec 5, 2022

github-actions bot commented Dec 5, 2022

github-actions bot commented Dec 5, 2022

jakirkham commented Dec 7, 2022 •

edited

Loading

jakirkham Dec 7, 2022

jakirkham commented Dec 7, 2022

noirello commented Dec 7, 2022 •

edited

Loading

jakirkham commented Dec 7, 2022 •

edited

Loading

galipremsagar commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

jakirkham commented Dec 9, 2022

kkraus14 commented Dec 9, 2022

jakirkham commented Dec 9, 2022

jakirkham commented Dec 9, 2022

jakirkham commented Dec 10, 2022

noirello commented Dec 11, 2022

github-actions bot commented Dec 11, 2022

noirello commented Dec 12, 2022 •

edited

Loading

kkraus14 commented Dec 12, 2022

kkraus14 commented Dec 12, 2022

noirello left a comment

jakirkham commented Dec 12, 2022

pyorc v0.8.0 #33

pyorc v0.8.0 #33

Conversation

regro-cf-autotick-bot commented Nov 19, 2022 • edited by jakirkham Loading

Dependency Analysis

Packages found by source code inspection but not in the meta.yaml:

conda-forge-linter commented Nov 19, 2022

galipremsagar commented Dec 5, 2022

github-actions bot commented Dec 5, 2022

github-actions bot commented Dec 5, 2022

jakirkham commented Dec 7, 2022 • edited Loading

jakirkham Dec 7, 2022

Choose a reason for hiding this comment

jakirkham commented Dec 7, 2022

noirello commented Dec 7, 2022 • edited Loading

jakirkham commented Dec 7, 2022 • edited Loading

galipremsagar commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

jakirkham commented Dec 9, 2022

kkraus14 commented Dec 9, 2022

jakirkham commented Dec 9, 2022

jakirkham commented Dec 9, 2022

jakirkham commented Dec 10, 2022

noirello commented Dec 11, 2022

github-actions bot commented Dec 11, 2022

noirello commented Dec 12, 2022 • edited Loading

kkraus14 commented Dec 12, 2022

kkraus14 commented Dec 12, 2022

noirello left a comment

Choose a reason for hiding this comment

jakirkham commented Dec 12, 2022

regro-cf-autotick-bot commented Nov 19, 2022 •

edited by jakirkham

Loading

jakirkham commented Dec 7, 2022 •

edited

Loading

noirello commented Dec 7, 2022 •

edited

Loading

jakirkham commented Dec 7, 2022 •

edited

Loading

noirello commented Dec 12, 2022 •

edited

Loading