Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM OSX Migrator #114

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2367376633, please use this URL for debugging.

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

@looooo i don't think cross compilation will work even for shiboken2 easily.

We could look through the patches: https://bugreports.qt.io/browse/PYSIDE-802?focusedCommentId=418104&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel

and see if there is anything we can do.

@hmaarrfk hmaarrfk marked this pull request as draft May 24, 2022 02:02
@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor

@looooo maybe this can help? conda-forge/tensorflow-feedstock@352e0e5

@looooo
Copy link
Contributor

looooo commented May 26, 2022

I will try this. How does this work? Do I have to call the instruction in the build.sh?

@hmaarrfk
Copy link
Contributor

I'm not sure how it works, but maybe just add those 3 lines to the bottom of build.sh

@hmaarrfk
Copy link
Contributor

hmm, not sure what OUTPUT is actually. maybe we can ask for help. Do you mind uploading a log of your builds?

@looooo
Copy link
Contributor

looooo commented May 26, 2022

I added the lines to the build.sh. Still failing with the same issue:
pyside2-osxarm64-output.txt

@hmaarrfk
Copy link
Contributor

@conda-forge/help-osx-arm64 can you please have a look at @looooo 's log file and comment on an appropriate approach.

@looooo
Copy link
Contributor

looooo commented Jun 7, 2022

@xhochy can you help with this PR? I guess we run into a similar issue as you were fixing for tensor flow. Can you explain what must be changed to make the code-sign work for osx-arm64?

[cctools-port]: generating fake signature for '/Users/lo/mambaforge/conda-bld/pyside2_1653604213252/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.9/site-packages/PySide2/QtQuick.cpython-39-darwin.so'
libc++abi: terminating with uncaught exception of type std::runtime_error: codesign_failed: 0

@bkpoon
Copy link
Member

bkpoon commented Jun 23, 2022

Can someone re-run the bot to resubmit this PR to resolve the conflicts? Then I can help get it ready for merging. Thanks!

@hmaarrfk hmaarrfk added the bot-rerun Instruct the bot to retry the PR label Jun 23, 2022
@hmaarrfk
Copy link
Contributor

@bkpoon you can always open a new fresh PR. hopefully this helps you out though

@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/autotick-bot/actions/runs/2551144640

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the bot-pr_arm_osx_had6325 branch June 23, 2022 18:23
@bkpoon
Copy link
Member

bkpoon commented Jun 23, 2022

@hmaarrfk Thanks! The PR is to get the os-arm64 builds working and I wanted to add commits on top of whatever the migrator does to keep things easier to merge.

@hmaarrfk
Copy link
Contributor

got it.

remember. we can always merge your work and close the migrator

@bkpoon
Copy link
Member

bkpoon commented Jun 24, 2022

@hmaarrfk I got everything to build and I did a brief check of one of the packages on my Apple Silicon laptop to verify that it works. There is an issue with resolving the build environment because it includes pyside2, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants