Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-debug build feature #86

Closed
wants to merge 7 commits into from

Conversation

dfroger
Copy link

@dfroger dfroger commented Nov 19, 2016

There are related disucssions here and here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This was referenced Nov 19, 2016
@edisongustavo
Copy link

This PR seems to change the default python to be compiled with pydebug.

I believe it is desired that both versions be compiled: with and without the pydebug feature.

@dfroger
Copy link
Author

dfroger commented Nov 21, 2016

Maybe I made the pull-request wrong in github, the intent was to add the code in a python-debug branch of the python-feedstock repo. (To avoid creating a new python-debug-feedstock repo, and simplify maintenance).

@dfroger
Copy link
Author

dfroger commented Nov 22, 2016

Doesn't seem to be possible to
pull request to a new upstream branch with GitHbub

@jjhelmus
Copy link
Contributor

@dfroger Thanks for putting this together, I'm excited about getting a debug build on Python on conda-forge. I went ahead and created a python-debug branch in this feedstock which you should be able to direct a pull request against. I think you may need to rerender the feedstock to get the CI services to start working.

@jakirkham
Copy link
Member

That SO answer is outdated @dfroger . They changed this maybe a couple of months back. Just click edit near the title and it will provide the option to change the base branch.

@dfroger dfroger changed the base branch from master to python-debug November 22, 2016 16:02
@dfroger
Copy link
Author

dfroger commented Nov 22, 2016

@jjhelmus @jakirkham thanks, I changed the base branch to python-debug.

When I build the package on my machine, the package is successfully created, but then the test failed due to the feature. I tried to add the feature metapackage to the test: requires: section, but without success.

I'm going to rerender the feedstock.

@jakirkham
Copy link
Member

So re-render is definitely needed. However, I don't think that alone will solve the issue. I think we need a new metapackage that helps us enable/disable the debug feature for Python. Though if someone has a better idea feel free to share.

cc @msarahan @pelson

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants