Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qiskit-aer v0.14 #34

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
ipython 8.23.0 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot, depfinder, or grayskull. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8506889068, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@wshanks
Copy link
Contributor

wshanks commented Apr 1, 2024

I forgot that I never merged #32. I will finish that one up and then come back to this one. It will be nice to have a new 0.13 build (by merging #32) because building now with pybind11 2.12 will provide numpy 2.0 compatibility.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@wshanks
Copy link
Contributor

wshanks commented Apr 5, 2024

Thanks @jakirkham! I can clean up the rest of the PR, I think. Can you give me any guidance on the pybind11 issue? I guess if there are issues with CUDA rendering in the future, I should compare to the upstream cuda120.yml and look at the specific problem to see if I need to sync with the upstream version of the migration or add an extra key like you did here. It seems like the pybind11 issue referenced in cuda120.yml was closed and there is a new release, but based on the discussion in conda-forge/nnpops-feedstock#34 it might still not be time to remove use_local yet?

@jakirkham
Copy link
Member

jakirkham commented Apr 5, 2024

Hey Will, it's a good question. There is a link to the pybind11 issue ( pybind/pybind11#4606 ) in the comment next to use_local. This issue was closed a while ago with a fix to pybind11 ( pybind/pybind11#4893 ), but it wasn't released until relatively recently in pybind11 2.12.0

So if we are able to use that version of pybind11, maybe we could try dropping this workaround. Admittedly this may not always be straightforward as some libraries (like PyTorch) vendor pybind11. Last I checked the PyTorch vendored pybind11 didn't have the fix, but that may have changed since

@wshanks
Copy link
Contributor

wshanks commented Apr 5, 2024

I will try it out in #32 first. Regarding vendored pybind11, does that only matter for projects that are linked against? Or also at run time? qiskit-aer doesn't link against anything else that uses pybind11. It uses pybind11 for interfaces to numpy and python and otherwise links to C libraries. So if it builds, is it okay to merge, or do we have to worry about someone installing qiskit-aer and pytorch in the same environment and having problems?

@jakirkham
Copy link
Member

For clarity, by vendor I meant PyTorch include pybind11's source in PyTorch somehow, which affects various downstream packages building with PyTorch as they will end up including PyTorch's copy of pybind11. If that is not your use case, wouldn't worry about it

As to pybind11's own ABI, yes it does have one. Agree I wouldn't think it would matter as long as the library using pybind11 doesn't expose pybind11 symbols somehow and doesn't pass pybind11 objects across library boundaries. Based on what you have said, it sounds like this isn't relevant for your case, but please correct me if I've misunderstood

@wshanks wshanks merged commit 17d3927 into conda-forge:main Apr 6, 2024
32 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.14_hc64f05 branch April 6, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants