Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build #103

Merged
merged 2 commits into from
Apr 25, 2019
Merged

Fix Windows build #103

merged 2 commits into from
Apr 25, 2019

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Apr 24, 2019

Trying to finish #102

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 24, 2019

My local build, and one of the Azure tries in #102, failed with:

jom: C:\Users\filipe\Miniconda3\envs\BUILD\conda-bld\qt_1556073246940\work\qtbase\src\angle\src\libGLESv2\Makefile [release] Error 2
jom: C:\Users\filipe\Miniconda3\envs\BUILD\conda-bld\qt_1556073246940\work\qtbase\src\angle\src\Makefile [sub-libGLESv2-release_ordered] Error 2
jom: C:\Users\filipe\Miniconda3\envs\BUILD\conda-bld\qt_1556073246940\work\qtbase\src\angle\Makefile [sub-src-release] Error 2
jom: C:\Users\filipe\Miniconda3\envs\BUILD\conda-bld\qt_1556073246940\work\qtbase\src\Makefile [sub-angle-release] Error 2
jom: C:\Users\filipe\Miniconda3\envs\BUILD\conda-bld\qt_1556073246940\work\qtbase\src\Makefile [sub-corelib-release] Error 2
jom: C:\Users\filipe\Miniconda3\envs\BUILD\conda-bld\qt_1556073246940\work\qtbase\Makefile [sub-src-release] Error 2
jom: C:\Users\filipe\Miniconda3\envs\BUILD\conda-bld\qt_1556073246940\work\Makefile [module-qtbase-release] Error 2

When I build it locally it first complained about a missing qmake, I installed the current version of qt and tried again and the build goes until the error above. Does that make sense @gillins? How do you circumvent the lack of qmake in your machine?

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 24, 2019

Pinging @mingwandroid and @isuruf here too, any insight you can give on building qt on Windows will be very helpful!

@gillins
Copy link
Contributor

gillins commented Apr 24, 2019

qmake got created as part of the build for me so i didn't have to do anything else. I didn't get that other error. You have VS 2015 installed on your machine?

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 24, 2019

qmake got created as part of the build for me

That is what I expected would happen :-/

You have VS 2015 installed on your machine?

Probably not then. I'll remove what I have and re-install it. Thanks!

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 24, 2019

@gillins and @msarahan I had that community VS version. What is the recommend one to build conda packages nowadays? I Google VS 2015 but ended up in a dead end in https://my.visualstudio.com/Downloads?q=visual%20studio%202015&wt.mc_id=o~msft~vscom~older-downloads

@tadeu
Copy link
Member

tadeu commented Apr 24, 2019

@ocefpaf, awesome to know that Qt is being updated! :D

At the end of this page there is a "Still want Visual Studio Express" section, where "Express 2015 for Windows Desktop" can be found: https://visualstudio.microsoft.com/vs/express/

There is also a Chocolatey package, if that helps: https://chocolatey.org/packages/VisualStudio2015Community

@ccordoba12 ccordoba12 changed the title bump Fix Windows build Apr 24, 2019
@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 24, 2019

Thanks @tadeu! I try that soon and report back.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 24, 2019

At the end of this page there is a "Still want Visual Studio Express" section, where "Express 2015 for Windows Desktop" can be found: https://visualstudio.microsoft.com/vs/express/

It goes to the same dead end 😄

Trying the community version again.

@gillins
Copy link
Contributor

gillins commented Apr 25, 2019

Does it take you to a login screen? I think you need a Microsoft ID to download anything these days...

If it is installed successfully you should have a bunch of files under C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC (I'd be a bit cautious about installing in anything other than the default location).

When you are running the installer make sure you select C++ as I have a feeling it isn't checked by default.

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 25, 2019

Does it take you to a login screen? I think you need a Microsoft ID to download anything these days...

Could be.

If it is installed successfully you should have a bunch of files under C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC (I'd be a bit cautious about installing in anything other than the default location).

When you are running the installer make sure you select C++ as I have a feeling it isn't checked by default.

I think I got it right with the community edition yesterday but the build did not end b/c Windows, against my configuration, decided to put the laptop to sleep.

I'm trying again this morning, I think it will work. (At some point yesterday I got the same error as you when copying the post file, I'm creating the folder now before copying. Fingers crossed.)

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 25, 2019

I got a successful build on Windows 🎉

Please let me know if you find any problem with it, the build is: https://anaconda.org/conda-forge/qt/5.9.7/download/win-64/qt-5.9.7-hc6833c9_1.tar.bz2

This was the last step to sync with AnacondaRecipes and to complete the openssl migration. Thanks to all who contribute to PRs #88, #91, #97, #98, and #102 (@hmaarrfk, @tadeu, @gillins, @marcelotrevisani, @mariusvniekerk, @mingwandroid, and @isuruf)!

@ocefpaf ocefpaf merged commit 953eaf6 into conda-forge:master Apr 25, 2019
@ocefpaf ocefpaf deleted the win branch April 25, 2019 17:42
@ccordoba12
Copy link
Contributor

Nice!! Thanks a lot for your help @ocefpaf!

@tadeu
Copy link
Member

tadeu commented Apr 26, 2019

Awesome! :D

I'm testing it locally, I've noticed that it is using a dependency from pkgs/main that is not yet in conda-forge:

vs2015_runtime           14.15.26706      h3a45250_0  pkgs/main

should this package be added to conda-forge?

@ocefpaf
Copy link
Member Author

ocefpaf commented Apr 26, 2019

should this package be added to conda-forge?

In theory we don't need to. With strict channel enabled you should get that one from defaults and the rest of from conda-forge without a problem. We, conda-forge, decided to not package the compilers run time at the moment.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 6, 2019

Did this ever build on a CI?

I'm getting strange errors on opencv trying to import cv2, which I assume is due to a qt issue?

conda-forge/opencv-feedstock#160

@ocefpaf
Copy link
Member Author

ocefpaf commented May 6, 2019

Did this ever build on a CI?

Only macOS.

I'm getting strange errors on opencv trying to import cv2, which I assume is due to a qt issue?

The version that hopefully "fixes" Windows was uploaded a few minutes ago. Can you please try again in ~30 min (until the index updates).

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 6, 2019

Ah, got it, thanks! Will try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants