-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows build #103
Fix Windows build #103
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
My local build, and one of the Azure tries in #102, failed with:
When I build it locally it first complained about a missing |
Pinging @mingwandroid and @isuruf here too, any insight you can give on building |
qmake got created as part of the build for me so i didn't have to do anything else. I didn't get that other error. You have VS 2015 installed on your machine? |
That is what I expected would happen :-/
Probably not then. I'll remove what I have and re-install it. Thanks! |
@gillins and @msarahan I had that community VS version. What is the recommend one to build conda packages nowadays? I Google VS 2015 but ended up in a dead end in https://my.visualstudio.com/Downloads?q=visual%20studio%202015&wt.mc_id=o~msft~vscom~older-downloads |
@ocefpaf, awesome to know that Qt is being updated! :D At the end of this page there is a "Still want Visual Studio Express" section, where "Express 2015 for Windows Desktop" can be found: https://visualstudio.microsoft.com/vs/express/ There is also a Chocolatey package, if that helps: https://chocolatey.org/packages/VisualStudio2015Community |
Thanks @tadeu! I try that soon and report back. |
It goes to the same dead end 😄 Trying the community version again. |
Does it take you to a login screen? I think you need a Microsoft ID to download anything these days... If it is installed successfully you should have a bunch of files under When you are running the installer make sure you select C++ as I have a feeling it isn't checked by default. |
Could be.
I think I got it right with the community edition yesterday but the build did not end b/c Windows, against my configuration, decided to put the laptop to sleep. I'm trying again this morning, I think it will work. (At some point yesterday I got the same error as you when copying the post file, I'm creating the folder now before copying. Fingers crossed.) |
I got a successful build on Windows 🎉 Please let me know if you find any problem with it, the build is: https://anaconda.org/conda-forge/qt/5.9.7/download/win-64/qt-5.9.7-hc6833c9_1.tar.bz2 This was the last step to sync with AnacondaRecipes and to complete the |
Nice!! Thanks a lot for your help @ocefpaf! |
Awesome! :D I'm testing it locally, I've noticed that it is using a dependency from
should this package be added to conda-forge? |
In theory we don't need to. With |
Did this ever build on a CI? I'm getting strange errors on opencv trying to import cv2, which I assume is due to a qt issue? |
Only macOS.
The version that hopefully "fixes" Windows was uploaded a few minutes ago. Can you please try again in ~30 min (until the index updates). |
Ah, got it, thanks! Will try. |
Trying to finish #102