Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Repin #88

Closed
wants to merge 139 commits into from
Closed

Conversation

mariusvniekerk
Copy link
Member

Closes #87

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 8, 2019

I think this would finish building if we split off qtwebkit
#99

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Apr 8, 2019

windows doesn't have space left on disk

d:\bld\qt_1554668640169\work\qtwebengine\src\3rdparty\chromium\build\precompile.cc: fatal error C1085: Cannot write precompiled header file: 'obj/storage/browser/browser_cc.pch': There is not enough space on the disk.

@ccordoba12
Copy link
Contributor

I think this would finish building if we split off qtwebkit

I don't know if that's advisable. I mean, it's better to talk to Microsoft first to get more time and space for the builds to finish.

MACOSX_DEPLOYMENT_TARGET: # [osx]
- '10.12' # [osx]
CONDA_BUILD_SYSROOT: # [osx]
- /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk # [osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the 2 entries above and do a rerender. conda-forge-ci-setup will add the correct path.

@@ -0,0 +1,4 @@
MACOSX_DEPLOYMENT_TARGET: # [osx]
- '10.12' # [osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this 10.12, but in the recipe 10.10 is used in lots of places?

recipe/build.sh Outdated
export CXX=${GXX}

mkdir -p "${SRC_DIR}/openssl_hack"
conda install -c https://repo.continuum.io/pkgs/main \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use conda-forge here?

@ocefpaf
Copy link
Member

ocefpaf commented Apr 9, 2019

@isuruf thanks for taking a look at this one! We need all the help we can get to bring this one home. @marcelotrevisani you have some experience building qt, if you can spare some minutes to take a look at this it would help us a lot.

Right now we are experiment segfaults downstream with pyqt (conda-forge/pyqt-feedstock#48), and the openssl migration has stalled here with qt.

@ccordoba12 ccordoba12 mentioned this pull request Apr 20, 2019
matrix:
win_cxx_compilervs2015vc14:
CONFIG: win_cxx_compilervs2015vc14
CONDA_BLD_PATH: D:\\bld\\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to C:? When building qgis this seemed to give more drive space (the lack of which seems to be the reason why the build is currently failing). I'm not sure if there are any issues with doing this though...

@looooo
Copy link
Contributor

looooo commented Apr 21, 2019

Trying to build the recipe in the docker container (linux-anvil-comp7) I get this error:

/opt/conda/conda-bld/qt_1555837302089/_test_envo/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: /opt/conda/conda-bld/qt_1555837302089/_test_env/lib/libQt5WebEngineCore.so: undefined reference to `dbus_message_set_serial@LIBDBUS_1_3'

@ccordoba12
Copy link
Contributor

@looooo, did you get that error while running the recipe's tests?

@looooo
Copy link
Contributor

looooo commented Apr 22, 2019

@looooo, did you get that error while running the recipe's tests?

yes, the compilation went fine but error occured during the tests. Package is uploaded to this channel:
https://anaconda.org/freecad/qt/files

@ccordoba12
Copy link
Contributor

yes, the compilation went fine but error occured during the tests

Those are fantastic news!! Let me fix the tests problem right away.

@ccordoba12
Copy link
Contributor

@conda-forge-admin, please rerender

@ccordoba12
Copy link
Contributor

@looooo, please try again. Things should work now.

@looooo
Copy link
Contributor

looooo commented Apr 22, 2019

@ccordoba12 done, worked. Tests are passing.
again uploaded to: https://anaconda.org/freecad/qt/files

@ocefpaf
Copy link
Member

ocefpaf commented Apr 22, 2019

@conda-forge-admin, please rerender

recipe/build.sh Outdated
@@ -59,7 +59,7 @@ if [[ ${HOST} =~ .*linux.* ]]; then
export CXX=${GXX}

mkdir -p "${SRC_DIR}/openssl_hack"
conda install -c https://repo.continuum.io/pkgs/main \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that conda-build did not even allow for that :-/

@@ -1,4 +1,2 @@
MACOSX_DEPLOYMENT_TARGET: # [osx]
- '10.12' # [osx]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf and @mingwandroid is the failure here related to 10.10? Should we force 10.12 for this build?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe macOS SDK 10.10 is what AD targets. We don't have a conda_build_config.yaml for Qt (or at least didn't for 5.9).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm quite lost in all the commit here. I'm also trying from a "fresh" PR based on AR but there I'm getting many undefined reference to dbus stuff, like:

lib/libQt5WebEngineCore.so: undefined reference to `dbus_message_set_serial@LIBDBUS_1_3'

In the past we had dbus from yum_requirements.txt but now we have a package in host. Not sure how to fix that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already fixed that in

e367b5d

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fixing run_exports in dbus so we can try to keep the recipe as close as possible to AR.

@ocefpaf ocefpaf mentioned this pull request Apr 22, 2019
@ocefpaf
Copy link
Member

ocefpaf commented Apr 24, 2019

Most of this PR is in Done in #102. Thanks to all 11 people who contributed to it!!

@ocefpaf ocefpaf closed this Apr 24, 2019
@ocefpaf ocefpaf mentioned this pull request Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rerender