Remove unnecessary CDTs

[hmaarrfk]

rebased onto main

• Closes Remove unnecessary CDTs #114
• Closes Do not leak CONDA_BUILD_SYSROOT and harden egl compilation ahead of cleanups #122

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[hmaarrfk]

@isuruf any clue which library is missing in the test section? I tried to keep both sections having the same CDTs.

undefined reference to `_XReply'

[isuruf]

You need cdt('libx11'). There are some wrong dependencies in mesa-libgl

[hmaarrfk]

Did you already check if any of these CDTs can be removed? If so, I'll just give up on this extra cleaning

[hmaarrfk]

I think i found a solution, but it requires one new xorg package.
conda-forge/staged-recipes#22084

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [62]

[hmaarrfk]

@conda-forge-admin please rerender

[conda-forge-webservices]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[hmaarrfk]

@conda-forge-admin please rerender

[hmaarrfk]

This is finally ready for review.

The main challenge is that EGL and GL require some X11 libraries so that pkg-config --exists egl passes. I found these libraries by dropping into the debug shell using python build-locally.py and using

pkg-config --debug --exists egl

and installed conda(-forge) packages as necessary.

I also added flags to the configure script to ensure that future maintainers cannot easily remove X11 dependencies without also breaking EGL

[ccordoba12]

Some small suggestions for you @hmaarrfk, otherwise looks good to me.

[hmaarrfk]

Given that this move is likely contentious, but also a very valuable cleanup, I would like to move forward on it on March 12 (2 weeks from now). It should give enough time for all to provide feedback on the current proposal.

[eddy-geek]

If I understand correctly, the build failures are the usual timeouts, so nothing is blocking this from being merged on March 12th as said above (#115 (comment)) ?
(I'm just tracking it as a gdal user as it appears to be a dependency for poppler and in turn conda-forge/gdal-feedstock#486 -- if I read the status correctly)

[hmaarrfk]

March 12th

correct. i am also building the other architectures right now (with emulation) so i'm really hoping that things are ready to go at this stage.

I do want to give "a saturday" for any final comments, but I think we really worked through many of the issues to make this a "clear improvement".

[hmaarrfk]

builds at https://anaconda.org/mark.harfouche/qt-main/files
logs qt-log.zip