Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 6.x #12

Closed
wants to merge 5 commits into from
Closed

Update to 6.x #12

wants to merge 5 commits into from

Conversation

jschueller
Copy link

@conda-forge-admin please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller jschueller force-pushed the qt6webengine branch 3 times, most recently from 741c347 to 4469cb4 Compare October 24, 2022 08:50
@jschueller
Copy link
Author

@conda-forge-admin please rerender

@github-actions
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/qt-webengine-feedstock/actions/runs/3312510490.

@jschueller jschueller mentioned this pull request Jan 10, 2023
Closed
@hmaarrfk
Copy link
Contributor

did this timeout, or fail?

@hmaarrfk hmaarrfk closed this Jan 10, 2023
@hmaarrfk hmaarrfk reopened this Jan 10, 2023
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jschueller
Copy link
Author

I dont remember

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • If python is a host requirement, it should be a run requirement.

@hmaarrfk
Copy link
Contributor

I think python 3.11 was tripping something up. Lets see if manually downgrading helps.

hmaarrfk
hmaarrfk reviewed Jan 11, 2023
View reviewed changes
recipe/build.sh

qmake QMAKE_LIBDIR=${PREFIX}/lib \
QMAKE_LFLAGS+="-Wl,-rpath,$PREFIX/lib -Wl,-rpath-link,$PREFIX/lib -L$PREFIX/lib" \
INCLUDEPATH+="${PREFIX}/include" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this include path, and these link parameters are important to maintain. it can't find libevent right now on linux.

@jschueller
Copy link
Author

giving up

@jschueller jschueller closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk left review comments

@Tobias-Fischer Tobias-Fischer Awaiting requested review from Tobias-Fischer Tobias-Fischer will be requested when the pull request is marked ready for review Tobias-Fischer is a code owner

@andfoy andfoy Awaiting requested review from andfoy andfoy will be requested when the pull request is marked ready for review andfoy is a code owner

@ccordoba12 ccordoba12 Awaiting requested review from ccordoba12 ccordoba12 will be requested when the pull request is marked ready for review ccordoba12 is a code owner

@duncanmmacleod duncanmmacleod Awaiting requested review from duncanmmacleod duncanmmacleod will be requested when the pull request is marked ready for review duncanmmacleod is a code owner

@gillins gillins Awaiting requested review from gillins gillins will be requested when the pull request is marked ready for review gillins is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid will be requested when the pull request is marked ready for review mingwandroid is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan will be requested when the pull request is marked ready for review msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf will be requested when the pull request is marked ready for review ocefpaf is a code owner

@stuarteberg stuarteberg Awaiting requested review from stuarteberg stuarteberg will be requested when the pull request is marked ready for review stuarteberg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschueller @conda-forge-linter @hmaarrfk