-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pip install
during the build to generate the dist-info
folder and add support for rdkit-stubs
#143
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
This is a bit hacky and this method won't work outside of building a conda package (like building a wheel for example) but it seems good enough for the benefits it brings without having to revisit the build process. |
…nda-forge-pinning 2023.12.04.19.29.31
@conda-forge/rdkit ready for review - please let me know what you think. I tested the package locally and it works well. |
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
Co-authored-by: Greg Landrum <greg.landrum@gmail.com>
Thanks for the review Greg. I don't have the permission to merge. Feel free to do so or wait for someone else review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but I don't really have much of an understanding of how the pip-conda interplay works.
@jaimergp do you have an opinion on this one or should we just go ahead and merge? |
pip install
during the build to generate the dist-info
folderpip install
during the build to generate the dist-info
folder and add support for rdkit-stubs
The latest commits bring the fix to the windows package as well, and also add a test that will fail if the Even if Once @greglandrum : would you be ok merging here? and in case anything goes wrong, I will fix it quick (but I am fairly confident we're good here). |
Yep, looks fine. Re: rdkit-stubs, I forgot to cherry-pick that PR onto the release branch, so it didn't end up in 2023.09.3. It will be in 2023.09.4 with some improvements that Paolo is working on now. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)The goal of this PR is to correctly add a
dist-info
folder to the conda package in order for python to detect rdkit is installed when the installation is coming from conda. It preventspip
to override rdkit from conda wheneverrdkit
is apip
dep.See the following tickets for context and history on this topic: