Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdkit as a pypi dep #219

Merged
merged 2 commits into from Dec 6, 2023
Merged

Add rdkit as a pypi dep #219

merged 2 commits into from Dec 6, 2023

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Dec 6, 2023

Changelogs


Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@hadim hadim added the feature label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c23d273) 91.95% compared to head (714919a) 91.93%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   91.95%   91.93%   -0.03%     
==========================================
  Files          46       46              
  Lines        3843     3843              
==========================================
- Hits         3534     3533       -1     
- Misses        309      310       +1     
Flag Coverage Δ
unittests 91.93% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hadim hadim merged commit 7186d2b into main Dec 6, 2023
15 checks passed
@hadim hadim deleted the pypi_dep branch December 6, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant