Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.7.1 #8

Closed
wants to merge 3 commits into from
Closed

Update to 0.7.1 #8

wants to merge 3 commits into from

Conversation

Luthaf
Copy link

@Luthaf Luthaf commented Jul 9, 2018

This replaces #4, #5, #6 and #7.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Luthaf
Copy link
Author

Luthaf commented Jul 9, 2018

I manually disabled test_setup_requires_keyword_include_cmake: https://github.com/scikit-build/scikit-build/blob/0db863127cd0a6cadde0c1bffd9a40fdf304fe2d/tests/test_setup.py#L309-L337, as it tries to download cmake, which is not possible inside conda build/test environment.

@jcfr
Copy link
Contributor

jcfr commented Jul 9, 2018

as it tries to download cmake, which is not possible inside conda build/test environment.

Makes sense. I will look into having the test disabled if there is no network connection or if it is running in conda.

Do you know if conda set an environment variable that I could check ?

windows failure

I will have a look and also add testing with miniconda in the scikit-build proper.

@isuruf
Copy link
Member

isuruf commented Jul 9, 2018

Do you know if conda set an environment variable that I could check ?

CONDA_BUILD

@jcfr
Copy link
Contributor

jcfr commented Jul 9, 2018

as it tries to download cmake, which is not possible inside conda build/test environment.

Since I would like to mention it it in the pytest.mark.skipif reason, does some know where this is documented ? (faq entry or mailing list post ...)

I looked at https://conda-forge.org/docs/testing.html but didn't find it.

@jcfr
Copy link
Contributor

jcfr commented Jul 9, 2018

xref scikit-build/scikit-build#332

@isuruf
Copy link
Member

isuruf commented Jul 9, 2018

conda/conda#508

This was referenced Jul 22, 2018
@moorepants
Copy link
Contributor

What is the status on this PR? I see the windows build is failing but am not familiar enough to know what exactly is going on.

@jcfr
Copy link
Contributor

jcfr commented Aug 21, 2018

The issue was fixed in master, after cutting release 0.8.0, this will be addressed.

@moorepants
Copy link
Contributor

Great thanks. We'd love to have this for our slycot builds.

@jcfr
Copy link
Contributor

jcfr commented Aug 21, 2018

New release of scikit-build has been pushed to pypi.

@jcfr
Copy link
Contributor

jcfr commented Aug 21, 2018

Closing. Superseded by #14

@jcfr jcfr closed this Aug 21, 2018
@Luthaf Luthaf deleted the v0.7.1 branch August 21, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants