Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for pypy #130

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://circleci.com/gh/regro/circle_worker/38243, please use this URL for debugging

regro-cf-autotick-bot added 2 commits August 10, 2020 19:44
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

@mattip
This is the second-largest blocker for the pypy-migration, currently. Timeout on ppc64le is suspicious (no response after 99% test suite), aarch has 4 errors:

=========================== short test summary info ============================
FAILED cluster/tests/test_mean_shift.py::test_parallel - joblib.externals.lok...
FAILED decomposition/tests/test_dict_learning.py::test_sparse_coder_parallel_mmap
FAILED manifold/tests/test_mds.py::test_MDS - joblib.externals.loky.process_e...
FAILED tests/test_multioutput.py::test_multi_output_classification_partial_fit_parallelism
= 4 failed, 14995 passed, 803 skipped, 81 xfailed, 10 xpassed, 2629 warnings in 1894.23s (0:31:34) =

AFAICT, they are all the same:

File "$PREFIX/lib-python/3/sre_compile.py", line 146, in _compile
 _compile(code, p, (flags | add_flags) & ~del_flags)
File "$PREFIX/lib-python/3/sre_compile.py", line 124, in _compile
emit(av[0])
IndexError: tuple index out of range

leading to:

E           joblib.externals.loky.process_executor.BrokenProcessPool: A task has failed to un-serialize. Please ensure that the arguments of the function are all picklable.

@conda-forge-admin, please rerender

@mattip
Copy link

mattip commented Sep 8, 2020

On ppc64le the tests take more than the allotted time, so the run is cancelled. Even on CPython they take 29 minutes, it is not uncommon for projects that heavily use the C-API to run tests more slowly on PyPy. Is there a way to identify and skip slow tests?

I will try to look into the ARM failure. FWIW, we are close to releasing an ABI-compatible newer version of PyPy with some bug fixes.

@mattip
Copy link

mattip commented Sep 8, 2020

Where is the complete aarch64 log?

@mattip
Copy link

mattip commented Sep 8, 2020

Found the relevant issue, https://foss.heptapod.net/pypy/pypy/-/issues/3188 (thanks @isuruf)

@h-vetinari
Copy link
Member

@mattip: Where is the complete aarch64 log?

It's here (from the CI button of the previous commit), but with the last rerun, the aarch-errors have disappeared.

Previous ppc64le run didn't look like a time-out (it ran 44 min 22 sec, not 50 min, which is the cut-off), but the last one definitely ran into that cut-off (at a much earlier stage of the test suite, ~52%)

@mattip
Copy link

mattip commented Sep 26, 2020

The aarch64 errors should be fixed by the recent 7.3.2 release

@mattip
Copy link

mattip commented Oct 4, 2020

7.3.2 is fully merged. @conda-forge-admin, please rerender

@mattip
Copy link

mattip commented Oct 4, 2020

Is that not the correct command to re-render? Edit: Re-rendered.

@mattip
Copy link

mattip commented Oct 4, 2020

bummer. PPC is still failing

@isuruf
Copy link
Member

isuruf commented Oct 4, 2020

Looks like a bug in the PyPy JIT

@mattip
Copy link

mattip commented Oct 4, 2020

Does this need re-rendering to blocklist ppc on pypy?

@mattip
Copy link

mattip commented Oct 5, 2020

Sorry to be a bother, but something is still off. ppc pypy is still in the build.

@isuruf
Copy link
Member

isuruf commented Oct 5, 2020

I've started a build locally to see if tests pass. If they do, we can disable tests for pypy and ppc64le here because we the 50 mins that travis-ci gives us not enough.

@mattip
Copy link

mattip commented Oct 11, 2020

@isuruf gentle ping

@isuruf
Copy link
Member

isuruf commented Oct 11, 2020

@conda-forge-admin, rerender

@mattip
Copy link

mattip commented Oct 11, 2020

ppc build is failing. How do we know it picked up the version after the ppc fixes in conda-forge/pypy3.6-feedstock#29?

@mattip
Copy link

mattip commented Oct 12, 2020

@conda-forge-admin, rerender.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@isuruf
Copy link
Member

isuruf commented Oct 12, 2020

How do we know it picked up the version after the ppc fixes in conda-forge/pypy3.6-feedstock#29?

In the logs you'll see pypy3.6: 7.3.2-h52a2fc7_1 conda-forge which implies that it is

@mattip
Copy link

mattip commented Oct 12, 2020

Whohoo - passed CI.

@mattip
Copy link

mattip commented Oct 14, 2020

Anything more need doing here before merging?

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@adrinjalali
Copy link
Member

This means we really need to fix the pypy issues on master now.

@mattip
Copy link

mattip commented Oct 18, 2020

Any chance of merging this?

@adrinjalali adrinjalali merged commit 9be35af into conda-forge:master Oct 18, 2020
@adrinjalali
Copy link
Member

@rth merged this, to give it a few weeks' distance between this and the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants