also enable recent patches on windows #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
force-pushed
the
cblas_win
branch
2 times, most recently
from
2bb09f1
to
73b8c72
Compare
h-vetinari
requested review from
jakirkham,
msarahan,
ocefpaf and
rgommers
as code owners
rgommers
approved these changes
May 10, 2023
There was a problem hiding this comment.
LGTM, thanks @h-vetinari. Feel free to merge now, or wait for another PR if that's better (potential merge conflict maybe, there's a lot going on).
| REM This builds a Fortran file which calls a C function, but numpy.distutils | ||
| REM creates an isolated DLL for these fortran functions and therefore it doesn't | ||
| REM see these C functions. workaround this by compiling it ourselves and | ||
| REM sneaking it with the blas libraries | ||
| REM TODO: rewrite wrap_g77_abi.f with iso_c_binding when the compiler supports it | ||
| cl.exe scipy\_build_utils\src\wrap_g77_abi_c.c -c /MD | ||
| cl.exe /I%NP_INC% /I%PY_INC% scipy\_build_utils\src\wrap_g77_abi_c.c -c /MD |
There was a problem hiding this comment.
This seems fine to me - whatever works really, since this line is a complete hack anyway that is going to disappear soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluded from #233 to make forward progress, I realised we should ensure these patches work on windows, so that 1.11 remains buildable with distutils.