Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scs c library #18

Open
1 task done
traversaro opened this issue Dec 20, 2020 · 7 comments
Open
1 task done

scs c library #18

traversaro opened this issue Dec 20, 2020 · 7 comments

Comments

@traversaro
Copy link

Hi @conda-forge/scs ! I am interested in providing the scs C library in conda-forge, in a form that can be consumed by C and C++ projects. At the moment this feedstock just installs the Python bindings of scs by statically linking the Python bindings with scs, and so the resulting library is not available to downstream C or C++ projects. I would be curious on your opinion regarding on this.

This issue is similar to conda-forge/osqp-feedstock#25, so I guess that @h-vetinari may have the same preference for having a multi output recipe, however other maintainers could be interested in provide other inputs.

@traversaro traversaro changed the title osqp c library scs c library Dec 20, 2020
@isuruf
Copy link
Member

isuruf commented Jan 1, 2021

Multi output recipes are fine for projects with the same release schedule, but it looks like scs python and C library have different maintainers/release schedules. So, a separate feedstock libscs and then the python package depending on libscs is a good approach I think

@traversaro
Copy link
Author

Thanks @isuruf . Indeed in this case (and also in osqp one) the maintainer is the same, but indeed the development is separated with the C library using the GitHub repo and releases from https://github.com/cvxgrp/scs, while the python one using the source code and releases from PyPI, that originate from https://github.com/bodono/scs-python .

@h-vetinari
Copy link
Member

Sounds good to me.

@traversaro, how do you feel about opening an addition for libscs to https://github.com/conda-forge/staged-recipes? You can also add me as a maintainer, if you want (and ping me, if you need help).

@traversaro
Copy link
Author

Perfect @h-vetinari, thanks for the reply!

@traversaro
Copy link
Author

For the libscs recipe, I would try to check if we are able to get a CMake build system in the upstream repo (see cvxgrp/scs#151), that could simplify the generation of Windows binaries.

@h-vetinari
Copy link
Member

A putative libscs-feedstock would also have to take care of GPU builds now - #21 is close to finished (but currently compiling the GPU version of scs here in this feedstock).

@traversaro
Copy link
Author

A putative libscs-feedstock would also have to take care of GPU builds now - #21 is close to finished (but currently compiling the GPU version of scs here in this feedstock).

Thanks for noticing. My plan was to use the newly added CMake-based buildsystem of scs (cvxgrp/scs#161) mainly to simplify the Windows port, but at the moment that does not support the GPU build. I will look into adding GPU support to that, I opened cvxgrp/scs#162 to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants