Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libosqp #13587

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Add libosqp #13587

merged 1 commit into from
Jan 6, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 2, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
  • When in trouble, please check our knowledge base documentation before pinging a team.

PR to add the C library for https://github.com/oxfordcontrol/osqp , as discussed in conda-forge/osqp-feedstock#25 . It is probably not ready as osqp uses a qdldl git submodule, that is not present in the release archive, see conda-forge/conda-forge.github.io#619 for a related discussion.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libosqp) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

The port should be now ready to be merged. Regarding vendored packages, at the moment osqp vendors qdldl, however de-vendoring it is not trivial ( see osqp/osqp#85) so for now it is included with its license, and once the libosqp-feedstock is in place I will work to remove it, before packaging other package that depend on qdldl as well (see conda-forge/scs-feedstock#18).

@traversaro
Copy link
Contributor Author

traversaro commented Jan 6, 2021

The PR is ready for review.
fyi @conda-forge/help-c-cpp (because the library is written in C) @wolfv (because the library is quite used in robotics, see for example https://github.com/ros-industrial-consortium/trajopt_ros and is also vendored in ROS2 : ros/rosdistro#27246) @conda-forge/osqp (for the discussion in conda-forge/osqp-feedstock#25)

@h-vetinari was added among the mantainers as he requested it in conda-forge/osqp-feedstock#25 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants