Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to noarch package #18

Merged
merged 6 commits into from Oct 23, 2023
Merged

Convert to noarch package #18

merged 6 commits into from Oct 23, 2023

Conversation

mattkram
Copy link
Contributor

@mattkram mattkram commented Aug 24, 2023 •
edited

The current package recipe brings in a platform-specific dependency on python_abi. This can cause some issues with dependency resolution when many other packages are included in the solve.

However, since this library is a simple Python package, we can build a python noarch package instead, which resolves these issues for us.

This PR converts the package from a platform-specific binary package to a noarch python package.

Checklist

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@mattkram
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits August 24, 2023 18:03
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@zaneselvans
Copy link

I'm trying to install this package using micromamba in a docker container doing development on an M1 Mac and running into an error because it's not available for the linux-aarch64 platform... which I imagine this switch to being a noarch package would fix...

@mtekman or @bgruening would you be up for merging it in?

@zaneselvans zaneselvans mentioned this pull request Oct 21, 2023
Merged
8 tasks
mtekman
mtekman reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@mtekman mtekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this effectively removes the win and osx targets, and replaces them with linux, which is no longer python version dependent?

@mattkram
Copy link
Contributor Author

So this effectively removes the win and osx targets, and replaces them with linux, which is no longer python version dependent?

This removes the OS-specific targets and replaces it with an OS/architecture-independent noarch package. This would get built on the Linux runners.

The python version can be specified via a normal pin if needed (e.g. python >=3.8), but this will drop the python_abi subdependency.

I have a noarch build that can be tried if interested: conda install -c anaconda-cloud simpleeval

https://anaconda.org/anaconda-cloud/simpleeval/files

@mattkram
Merge branch 'main' into noarch
73bb13c 
# Conflicts:
#	.azure-pipelines/azure-pipelines-linux.yml
#	.azure-pipelines/azure-pipelines-osx.yml
#	.azure-pipelines/azure-pipelines-win.yml
#	.ci_support/linux_64_.yaml
#	.ci_support/linux_64_python3.10.____cpython.yaml
#	.ci_support/linux_64_python3.12.____cpython.yaml
#	.ci_support/linux_64_python3.8.____cpython.yaml
#	.ci_support/linux_64_python3.9.____73_pypy.yaml
#	.ci_support/linux_64_python3.9.____cpython.yaml
#	.ci_support/osx_64_python3.10.____cpython.yaml
#	.ci_support/osx_64_python3.11.____cpython.yaml
#	.ci_support/osx_64_python3.12.____cpython.yaml
#	.ci_support/osx_64_python3.8.____cpython.yaml
#	.ci_support/osx_64_python3.9.____73_pypy.yaml
#	.ci_support/osx_64_python3.9.____cpython.yaml
#	.ci_support/osx_arm64_python3.10.____cpython.yaml
#	.ci_support/osx_arm64_python3.11.____cpython.yaml
#	.ci_support/osx_arm64_python3.8.____cpython.yaml
#	.ci_support/osx_arm64_python3.9.____cpython.yaml
#	.ci_support/win_64_python3.10.____cpython.yaml
#	.ci_support/win_64_python3.11.____cpython.yaml
#	.ci_support/win_64_python3.12.____cpython.yaml
#	.ci_support/win_64_python3.8.____cpython.yaml
#	.ci_support/win_64_python3.9.____73_pypy.yaml
#	.ci_support/win_64_python3.9.____cpython.yaml
#	.scripts/build_steps.sh
#	.scripts/run_osx_build.sh
#	README.md
@mattkram
Copy link
Contributor Author

@conda-forge-admin, please rerender

@mattkram
Copy link
Contributor Author

@mtekman thanks for the review! I've just merged in the latest main branch and re-rendered the feedstocks. Should be good to go now once you're happy w/ it.

@mtekman mtekman merged commit b0efb80 into conda-forge:main Oct 23, 2023
3 checks passed
@mtekman
Copy link
Contributor

mtekman commented Oct 23, 2023

Nice, thanks for the upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtekman mtekman mtekman approved these changes

@bgruening bgruening Awaiting requested review from bgruening bgruening is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattkram @zaneselvans @mtekman