-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pynio and its dependencies. #100
Conversation
f07fcb5
to
a3ad5cc
Compare
|
||
test: | ||
commands: | ||
- conda inspect linkages g2clib --name _test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if these were making an assertion (like: the linkages should include x, y, z, and they should all come from $PREFIX, or something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. They are not real tests right now... I will come up with something slightly better than this.
|
I have no idea that is going on with |
|
||
test: | ||
commands: | ||
- exit $(test -f ${PREFIX}/lib/libgrib2c.a) # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably do much better with conda inspect
, but for now I went lazy and added a simple test to assert the lib exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is IMHO the area of most concern for Windows builds atm. We should invest some time in getting a solid testing strategy on Windows. @JanSchulz may be able to help in this regard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can run some tests, but my problem is more that I've mostly no clue how to test such libs :-/
If it should just test for the existence: cmd /c IF NOT EXIST "%ProgramFiles%\7-Zip\7z.dll" EXIT /B 1
@pelson can you take a second look at these? |
- zlib | ||
- jpeg | ||
- jasper | ||
- gcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the story with gcc
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remember... I will try a PR to the feedstock later to see if there is a reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, there are a few in this PR like this one. Let's see if we can't drop them. I know I saw some issues with libiconv
related to this so we should see if we can't just avoid Continuum's gcc
and use system compilers instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for libiconv
and I will do the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. No problem.
Ping @jhamman. This is the last PR before adding
xarray
.