Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pynio and its dependencies. #100

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Mar 14, 2016

Ping @jhamman. This is the last PR before adding xarray.

@ocefpaf ocefpaf force-pushed the xarray_deps branch 3 times, most recently from f07fcb5 to a3ad5cc Compare March 14, 2016 15:54

test:
commands:
- conda inspect linkages g2clib --name _test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if these were making an assertion (like: the linkages should include x, y, z, and they should all come from $PREFIX, or something)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. They are not real tests right now... I will come up with something slightly better than this.

@pelson
Copy link
Member

pelson commented Mar 15, 2016

+conda inspect linkages libiconv --name _test

An unexpected error has occurred, please consider sending the

following traceback to the conda GitHub issue tracker at:



    https://github.com/conda/conda-build/issues



Include the output of the command 'conda info' in your report.





Traceback (most recent call last):

  File "/Users/travis/miniconda/bin/conda-inspect", line 5, in <module>

    sys.exit(main())

  File "/Users/travis/miniconda/lib/python2.7/site-packages/conda_build/main_inspect.py", line 155, in main

    args_func(args, p)

  File "/Users/travis/miniconda/lib/python2.7/site-packages/conda_build/main_build.py", line 478, in args_func

    args.func(args, p)

  File "/Users/travis/miniconda/lib/python2.7/site-packages/conda_build/main_inspect.py", line 307, in execute

    linkages = get_linkages(obj_files, prefix)

  File "/Users/travis/miniconda/lib/python2.7/site-packages/conda/utils.py", line 118, in __call__

    value = self.func(*args, **kw)

  File "/Users/travis/miniconda/lib/python2.7/site-packages/conda_build/ldd.py", line 51, in get_linkages

    res[f] = [(basename(l), l) for l in links]

  File "/Users/travis/miniconda/lib/python2.7/posixpath.py", line 114, in basename

    i = p.rfind('/') + 1

AttributeError: 'dict' object has no attribute 'rfind'

TESTS FAILED: libiconv-1.14-0

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 15, 2016

I have no idea that is going on with libiconv. This recipe worked in IOOS before, so I am guessing something changed in conda-build recently.


test:
commands:
- exit $(test -f ${PREFIX}/lib/libgrib2c.a) # [not win]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably do much better with conda inspect, but for now I went lazy and added a simple test to assert the lib exists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is IMHO the area of most concern for Windows builds atm. We should invest some time in getting a solid testing strategy on Windows. @JanSchulz may be able to help in this regard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can run some tests, but my problem is more that I've mostly no clue how to test such libs :-/

If it should just test for the existence: cmd /c IF NOT EXIST "%ProgramFiles%\7-Zip\7z.dll" EXIT /B 1

@ocefpaf
Copy link
Member Author

ocefpaf commented Mar 15, 2016

@pelson can you take a second look at these?

pelson added a commit that referenced this pull request Mar 16, 2016
Pynio and its dependencies.
@pelson pelson merged commit faa916a into conda-forge:master Mar 16, 2016
@ocefpaf ocefpaf deleted the xarray_deps branch March 16, 2016 10:10
@ocefpaf ocefpaf mentioned this pull request Mar 16, 2016
- zlib
- jpeg
- jasper
- gcc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the story with gcc here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remember... I will try a PR to the feedstock later to see if there is a reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, there are a few in this PR like this one. Let's see if we can't drop them. I know I saw some issues with libiconv related to this so we should see if we can't just avoid Continuum's gcc and use system compilers instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for libiconv and I will do the rest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants