Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hiplot #10929

Merged
merged 8 commits into from
Feb 25, 2020
Merged

add hiplot #10929

merged 8 commits into from
Feb 25, 2020

Conversation

rpanai
Copy link
Contributor

@rpanai rpanai commented Feb 25, 2020 •
edited

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/hiplot) and found it was in an excellent condition.

npavlovikj
npavlovikj reviewed Feb 25, 2020
View reviewed changes
recipes/hiplot/meta.yaml Outdated

requirements:
host:
- beautifulsoup4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually pip and python are the only dependencies that should go in host, and everything else goes to run. Can you please try that?

npavlovikj
npavlovikj reviewed Feb 25, 2020
View reviewed changes
recipes/hiplot/meta.yaml Outdated
license_family: MIT
license_file: LICENSE
summary: "High dimensional Interactive Plotting tool"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add doc_url: https://facebookresearch.github.io/hiplot/.

npavlovikj
npavlovikj reviewed Feb 25, 2020
View reviewed changes
recipes/hiplot/meta.yaml
license_file: LICENSE
summary: "High dimensional Interactive Plotting tool"


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@npavlovikj npavlovikj merged commit e4e0df1 into conda-forge:master Feb 25, 2020
@npavlovikj
Copy link
Contributor

The recipe LGTM @rpanai , thank you for contributing 🎉

@rpanai rpanai mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npavlovikj npavlovikj npavlovikj left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rpanai @conda-forge-linter @npavlovikj