Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add win10toast recipe #11051

Merged
merged 2 commits into from Apr 2, 2020
Merged

Add win10toast recipe #11051

merged 2 commits into from Apr 2, 2020

Conversation

setu4993
Copy link
Contributor

@setu4993 setu4993 commented Mar 13, 2020 •
edited

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/win10toast) and found it was in an excellent condition.

@setu4993 setu4993 closed this Mar 13, 2020
@setu4993 setu4993 reopened this Mar 15, 2020
@setu4993
Copy link
Contributor Author

@conda-forge/staged-recipes : This PR is ready for review.

scopatz
scopatz requested changes Mar 15, 2020
View reviewed changes
Copy link
Member

@scopatz scopatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build from source, not wheels

scopatz
scopatz reviewed Mar 15, 2020
View reviewed changes
recipes/win10toast/meta.yaml Outdated
version: {{ version }}

source:
git_url: https://github.com/jithurjacob/Windows-10-Toast-Notifications.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install from a tarball rather than a repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, there is no tarball available for this project (on PyPi or on GitHub releases).

Copy link
Member

@scopatz scopatz Mar 16, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github will generate a tarball for you if it is tagged though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tags on the repo either :/.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I think we need to encourage the devs to release an actual source tarball, either with twine sdist or by git tag

Copy link
Contributor Author

@setu4993 setu4993 Mar 16, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but as I mentioned in a comment, it is a package that hasn't been updated in a while even for simple fixes (one of which required the patch), and has multiple open, unresponded PRs. The absence of this recipe was blocking a version update on another project that I contribute to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Anthony that the developers should be encouraged to release an official tarball, so opening an issue regarding wouldn't hurt.

Looks like the PyPI wheel was updated on 01/25/2018 which corresponds with commit "9d52b73f1af6c60162cf09b99269c4f7b13cdb00", so maybe url: https://github.com/jithurjacob/Windows-10-Toast-Notifications/archive/9d52b73.tar.gz can be used in the meantime ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no tag in github, I don't see an issue with using the wheel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's why I used a wheel at start. Happy to use the tarball from the latest commit and opening an issue at source requesting a tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched source to the commit tarball, opened an issue at source.

@setu4993
Copy link
Contributor Author

@scopatz : Thanks for taking a look at this and the recommendations. I cannot find a tarball for this package on PyPi, which is why I went the wheel way, and am now trying to get the github source working.

It is quite an outdated package that hasn't been updated in >1 year and some recent PRs for fixes at source are not updated.

@setu4993 setu4993 requested a review from scopatz March 15, 2020 22:57
@setu4993
Add win10toast recipe
3d57d1f 
Switch to git source

Add patch to recipe
@setu4993
Copy link
Contributor Author

Thanks for reviewing and approving, @scopatz!

@setu4993
Copy link
Contributor Author

@conda-forge/staged-recipes : Bump, can someone please merge this?

@setu4993
Copy link
Contributor Author

setu4993 commented Apr 2, 2020

@conda-forge/staged-recipes : Bump, this is ready to merge.

@isuruf isuruf merged commit 018ffab into conda-forge:master Apr 2, 2020
@setu4993 setu4993 deleted the win10toast branch April 3, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@npavlovikj npavlovikj npavlovikj left review comments

@isuruf isuruf isuruf left review comments

@scopatz scopatz scopatz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@setu4993 @conda-forge-linter @scopatz @jakirkham @npavlovikj @isuruf