Skip to content

Add win10toast recipe - #11051

Merged
isuruf merged 2 commits into
conda-forge:masterfrom
setu4993:win10toast
Apr 2, 2020
Merged

Add win10toast recipe#11051
isuruf merged 2 commits into
conda-forge:masterfrom
setu4993:win10toast

Conversation

@setu4993

@setu4993 setu4993 commented Mar 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter

conda-forge-linter commented Mar 13, 2020

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/win10toast) and found it was in an excellent condition.

@setu4993 setu4993 closed this Mar 13, 2020
@setu4993 setu4993 reopened this Mar 15, 2020
@setu4993

setu4993 commented Mar 15, 2020

Copy link
Copy Markdown
Member Author

@conda-forge/staged-recipes : This PR is ready for review.

scopatz
scopatz reviewed Mar 15, 2020
View reviewed changes
Comment thread recipes/win10toast/meta.yaml Outdated
scopatz
scopatz reviewed Mar 15, 2020
View reviewed changes
Comment thread recipes/win10toast/meta.yaml Outdated
scopatz
scopatz requested changes Mar 15, 2020
View reviewed changes

@scopatz scopatz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build from source, not wheels

scopatz
scopatz reviewed Mar 15, 2020
View reviewed changes
Comment thread recipes/win10toast/meta.yaml Outdated

@scopatz scopatz Mar 15, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please install from a tarball rather than a repo

@setu4993 setu4993 Mar 15, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, there is no tarball available for this project (on PyPi or on GitHub releases).

@scopatz scopatz Mar 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github will generate a tarball for you if it is tagged though

@setu4993 setu4993 Mar 16, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tags on the repo either :/.

@scopatz scopatz Mar 16, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I think we need to encourage the devs to release an actual source tarball, either with twine sdist or by git tag

@setu4993 setu4993 Mar 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but as I mentioned in a comment, it is a package that hasn't been updated in a while even for simple fixes (one of which required the patch), and has multiple open, unresponded PRs. The absence of this recipe was blocking a version update on another project that I contribute to.

@npavlovikj npavlovikj Mar 16, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Anthony that the developers should be encouraged to release an official tarball, so opening an issue regarding wouldn't hurt.

Looks like the PyPI wheel was updated on 01/25/2018 which corresponds with commit "9d52b73f1af6c60162cf09b99269c4f7b13cdb00", so maybe url: https://github.com/jithurjacob/Windows-10-Toast-Notifications/archive/9d52b73.tar.gz can be used in the meantime ?

@isuruf isuruf Mar 16, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no tag in github, I don't see an issue with using the wheel.

@setu4993 setu4993 Mar 16, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's why I used a wheel at start. Happy to use the tarball from the latest commit and opening an issue at source requesting a tag.

@setu4993 setu4993 Mar 16, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched source to the commit tarball, opened an issue at source.

@setu4993

setu4993 commented Mar 15, 2020

Copy link
Copy Markdown
Member Author

@scopatz : Thanks for taking a look at this and the recommendations. I cannot find a tarball for this package on PyPi, which is why I went the wheel way, and am now trying to get the github source working.

It is quite an outdated package that hasn't been updated in >1 year and some recent PRs for fixes at source are not updated.

@setu4993
setu4993 requested a review from scopatz March 15, 2020 22:57
@setu4993
Add win10toast recipe
3d57d1f 
Switch to git source

Add patch to recipe
jakirkham
jakirkham reviewed Mar 16, 2020
View reviewed changes
Comment thread recipes/win10toast/meta.yaml
@setu4993

setu4993 commented Mar 16, 2020

Copy link
Copy Markdown
Member Author

Thanks for reviewing and approving, @scopatz!

@setu4993

setu4993 commented Mar 22, 2020

Copy link
Copy Markdown
Member Author

@conda-forge/staged-recipes : Bump, can someone please merge this?

@setu4993

setu4993 commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

@conda-forge/staged-recipes : Bump, this is ready to merge.

@isuruf
isuruf merged commit 018ffab into conda-forge:master Apr 2, 2020
@setu4993
setu4993 deleted the win10toast branch April 3, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham left review comments
@npavlovikj npavlovikj npavlovikj left review comments
@isuruf isuruf isuruf left review comments
@scopatz scopatz scopatz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@setu4993 @conda-forge-linter @scopatz @jakirkham @npavlovikj @isuruf