Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add physical_validation recipe #11370

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Apr 24, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/physical_validation) and found some lint.

Here's what I've got...

For recipes/physical_validation:

  • The recipe must have some tests.
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipes/physical_validation:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission. I added a couple of notes to clean things up and hopefully get the CI passing. Also, please get confirmation from the other listed co-maintainers

- scipy
- pymbar

#test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these comments

noarch: python
number: 0
script: "{{ PYTHON }} -m pip install . -vv"
skip: True # [py<35]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda-forge is no longer building packages based on python 2.7 so you can remove the skip: True statement

version: {{ version }}

source:
url: https://github.com/shirtsgroup/physical_validation/archive/{{ version }}.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the url should be:

https://github.com/shirtsgroup/physical_validation/archive/v{{ version }}.tar.gz

note the missing v before the version templating.


about:
home: https://github.com/shirtsgroup/physical_validation
license: LGPL-2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To satisfy the spdx descriptors you need either LGPL-2.1-only or LGPL-2.1-or-later. See:

https://spdx.org/licenses/

@stale
Copy link

stale bot commented Sep 22, 2020

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Sep 22, 2020
@mattwthompson
Copy link
Member Author

Indeed, this has gone stale. Will re-open if we pick it back up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

3 participants