-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add physical_validation recipe #11370
Add physical_validation recipe #11370
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/physical_validation:
For recipes/physical_validation:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission. I added a couple of notes to clean things up and hopefully get the CI passing. Also, please get confirmation from the other listed co-maintainers
- scipy | ||
- pymbar | ||
|
||
#test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these comments
noarch: python | ||
number: 0 | ||
script: "{{ PYTHON }} -m pip install . -vv" | ||
skip: True # [py<35] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-forge is no longer building packages based on python 2.7 so you can remove the skip: True
statement
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/shirtsgroup/physical_validation/archive/{{ version }}.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the url should be:
https://github.com/shirtsgroup/physical_validation/archive/v{{ version }}.tar.gz
note the missing v
before the version templating.
|
||
about: | ||
home: https://github.com/shirtsgroup/physical_validation | ||
license: LGPL-2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To satisfy the spdx descriptors you need either LGPL-2.1-only
or LGPL-2.1-or-later
. See:
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the Cheers and thank you for contributing to this community effort! |
Indeed, this has gone stale. Will re-open if we pick it back up |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)