Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for rstcheck #12027

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Add recipe for rstcheck #12027

merged 2 commits into from
Jul 2, 2020

Conversation

kynan
Copy link
Contributor

@kynan kynan commented Jun 28, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rstcheck) and found it was in an excellent condition.

@kynan
Copy link
Contributor Author

kynan commented Jun 28, 2020

@conda-forge/help-python no idea why the build fails on Windows. Something appears to go wrong linking the entry-point executable?

@scopatz
Copy link
Member

scopatz commented Jun 29, 2020

@kynan - It is noarch python, so it only needs to run on linux

@kynan
Copy link
Contributor Author

kynan commented Jun 30, 2020

Adding the entrypoint fixed this, thanks Anthony! I believe this is now good to go @conda-forge/help-python

imports:
- rstcheck
commands:
- python -m rstcheck --help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add pip check here please?

Suggested change
- python -m rstcheck --help
- python -m rstcheck --help
- pip check
requires:
- pip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see this in time. Added now!

@scopatz scopatz merged commit b21ccd7 into conda-forge:master Jul 2, 2020
@kynan kynan deleted the rstcheck branch July 3, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants