-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recipe for mplfinance #13204
add recipe for mplfinance #13204
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/mplfinance:
Documentation on acceptable licenses can be found here. |
Hi @conda-forge/help-python |
Took some poking around, but I managed to find the build log on dev.azure.com and it was clearly complaining about the license file. So trying a different specification for the license file. |
I am now getting the error:
but the link (https://github.com/matplotlib/mplfinance/blob/master/LICENSE) is the actual license file. I am beginning to get the idea that I need to copy the license file into my recipes directory. I'd like to avoid doing that if possible, because I don't want to have two license files that can possibly get out of sync: one in the matplotlib/mplfinance repostory, and one in the conda-forge/staged-recipes repository. @conda-forge-coordinator - please advise. thank you. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@synapticarbors |
@DanielGoldfarb -- Thank you for your contribution to conda-forge! Once the feedstock for this package is created if you run into any problems, please don't hesitate to ping the team for help. In terms of how long a PR takes to get merged, it's highly dependent on how busy the reviewers are. We try to turn most PRs around within a day or so when possible. |
This is my first time contributing a package to conda-forge.
I think I've got everything right. The only thing I am aware of having doubts about is the license file. I entered a url to the license. Not sure if I should rather be doing something else.
My recipe was generated with
conda skeleton pypi mplfinance
with a small amount of manual editing after that. I used conda-build and anaconda upload, and then tested installing from https://anaconda.org/DanielGoldfarb/mplfinance and it worked.Let me know if there is anything else I need to do in order to get this into conda-forge. Thank you.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)