Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for mplfinance #13204

Merged
merged 6 commits into from
Nov 13, 2020
Merged

add recipe for mplfinance #13204

merged 6 commits into from
Nov 13, 2020

Conversation

DanielGoldfarb
Copy link
Contributor

This is my first time contributing a package to conda-forge.

I think I've got everything right. The only thing I am aware of having doubts about is the license file. I entered a url to the license. Not sure if I should rather be doing something else.

My recipe was generated with conda skeleton pypi mplfinance with a small amount of manual editing after that. I used conda-build and anaconda upload, and then tested installing from https://anaconda.org/DanielGoldfarb/mplfinance and it worked.

Let me know if there is anything else I need to do in order to get this into conda-forge. Thank you.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • [ ? ] License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mplfinance) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mplfinance:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@DanielGoldfarb
Copy link
Contributor Author

Hi @conda-forge/help-python
I could use some help. I see some checks failed. The error message (for linux_64 linux, for example) is bash exited with code '1' ...
I have no idea what was run that exited with code '1'. Please help. I'm a first time conda-forge contributor. Thank you. --Daniel

@DanielGoldfarb
Copy link
Contributor Author

Took some poking around, but I managed to find the build log on dev.azure.com and it was clearly complaining about the license file. So trying a different specification for the license file.

@DanielGoldfarb
Copy link
Contributor Author

DanielGoldfarb commented Nov 12, 2020

I am now getting the error:

ValueError: License file given in about/license_file (/home/conda/staged-recipes-copy/recipes/mplfinance/https://github.com/matplotlib/mplfinance/blob/master/LICENSE) does not exist in source root dir or in recipe root dir (with meta.yaml)

but the link (https://github.com/matplotlib/mplfinance/blob/master/LICENSE) is the actual license file.

I am beginning to get the idea that I need to copy the license file into my recipes directory. I'd like to avoid doing that if possible, because I don't want to have two license files that can possibly get out of sync: one in the matplotlib/mplfinance repostory, and one in the conda-forge/staged-recipes repository.

@conda-forge-coordinator - please advise. thank you.

recipes/mplfinance/meta.yaml Outdated Show resolved Hide resolved
recipes/mplfinance/meta.yaml Outdated Show resolved Hide resolved
recipes/mplfinance/meta.yaml Outdated Show resolved Hide resolved
recipes/mplfinance/meta.yaml Outdated Show resolved Hide resolved
recipes/mplfinance/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mplfinance) and found it was in an excellent condition.

@DanielGoldfarb
Copy link
Contributor Author

@synapticarbors
Joshua, What is the normal time expectation for a PR like this to get merged (once review changes have been made)??
Thanks. --Daniel

@synapticarbors synapticarbors merged commit 322d382 into conda-forge:master Nov 13, 2020
@synapticarbors
Copy link
Member

@DanielGoldfarb -- Thank you for your contribution to conda-forge! Once the feedstock for this package is created if you run into any problems, please don't hesitate to ping the team for help.

In terms of how long a PR takes to get merged, it's highly dependent on how busy the reviewers are. We try to turn most PRs around within a day or so when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants