Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ipydrawio 1.0.1 #14528

Merged
merged 13 commits into from
Apr 12, 2021
Merged

add ipydrawio 1.0.1 #14528

merged 13 commits into from
Apr 12, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Apr 11, 2021 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
    • all packages covered under main Apache-2.0
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Notes:

  • there are some clobber warnings between the two packages, will patch here and fix upstream

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ipydrawio) and found it was in an excellent condition.

@bollwyvl
Copy link
Contributor Author

Hm, don't know what to do about the long windows paths...

@bollwyvl bollwyvl mentioned this pull request Apr 11, 2021
Closed
13 tasks
@bollwyvl
Copy link
Contributor Author

Going to try working the path length stuff upstream... basically impossible to patch from the sdist alone...

@bollwyvl bollwyvl closed this Apr 12, 2021
@bollwyvl bollwyvl reopened this Apr 12, 2021
@bollwyvl bollwyvl changed the title add ipydrawio 1.0.0 add ipydrawio 1.0.1 Apr 12, 2021
@bollwyvl
Copy link
Contributor Author

I shaved about 30 characters off... some of the paths. We'll see how it goes!

@bollwyvl bollwyvl mentioned this pull request Apr 12, 2021
Closed
14 tasks
@bollwyvl
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-python ready for review!

isuruf
isuruf reviewed Apr 12, 2021
View reviewed changes
recipes/ipydrawio/meta.yaml

extra:
recipe-maintainers:
- bollwyvl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- bollwyvl
- bollwyvl
feedstock-name: ipydrawio

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

876af84

isuruf
isuruf reviewed Apr 12, 2021
View reviewed changes
recipes/ipydrawio/meta.yaml Outdated
{% set build_number = 0 %}

package:
name: {{ name }}-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a s/{{ name }}/ipydrawio/g for this file? It's hurting readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a9534c2

@bollwyvl
Copy link
Contributor Author

Thanks for the speedy review! Have updated from comments...

@isuruf
Copy link
Member

isuruf commented Apr 12, 2021

What's the reason for having one recipe instead of 2 for two different packages?

@bollwyvl
Copy link
Contributor Author

one recipe instead of 2 for two different packages?

It's to avoid the heavy dependencies (node) on the pdf export side. They are both cut from the same tag... in an ideal world they would be the same (python) package, but I tire of extras... and not everybody's on conda 😿

@isuruf isuruf merged commit 2c15576 into conda-forge:master Apr 12, 2021
@bollwyvl
Copy link
Contributor Author

Thanks!

@bollwyvl bollwyvl mentioned this pull request Apr 12, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bollwyvl @conda-forge-linter @isuruf