Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yambo #14727

Merged
merged 16 commits into from
Jun 1, 2021
Merged

add yambo #14727

merged 16 commits into from
Jun 1, 2021

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Apr 25, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/yambo) and found some lint.

Here's what I've got...

For recipes/yambo:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/yambo) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/yambo:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/yambo) and found it was in an excellent condition.

@ltalirz
Copy link
Member Author

ltalirz commented Apr 27, 2021

@conda-forge/staged-recipes, ready for review

@ltalirz
Copy link
Member Author

ltalirz commented Apr 27, 2021

comment confirming interest by maintainer yambo-code/yambo#34 (comment)

@ltalirz
Copy link
Member Author

ltalirz commented May 13, 2021

@conda-forge/staged-recipes, ready for review

recipes/yambo/build.sh Outdated Show resolved Hide resolved
- fftw
- libblas
- liblapack
- wget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is wget needed in host? I would assume it’s more likely to be a build dependency? (Build if it’s used for downloads, host if you link against it)

if it is being used for downloads, they should probably be included in the sources section instead

Copy link
Member Author

@ltalirz ltalirz May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I think you are right - it will only be needed in build - fixed!

if it is being used for downloads, they should probably be included in the sources section instead

I'm going to assume you meant "build: section" here as well - please correct me if you meant something else

ltalirz and others added 2 commits May 13, 2021 20:38
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@ltalirz
Copy link
Member Author

ltalirz commented May 13, 2021

@conda-forge/staged-recipes, ready for re-review

1 similar comment
@ltalirz
Copy link
Member Author

ltalirz commented May 25, 2021

@conda-forge/staged-recipes, ready for re-review

@ltalirz
Copy link
Member Author

ltalirz commented May 30, 2021

@conda-forge/staged-recipes @chrisburr , ready for re-review

@chrisburr chrisburr merged commit 7fac787 into conda-forge:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants