-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add yambo #14727
add yambo #14727
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/yambo:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/yambo:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
the actual libraries conda complained about were "zlib" and "libcurl". if this doesn't fix it, I might need to add those as well
@conda-forge/staged-recipes, ready for review |
comment confirming interest by maintainer yambo-code/yambo#34 (comment) |
@conda-forge/staged-recipes, ready for review |
recipes/yambo/meta.yaml
Outdated
- fftw | ||
- libblas | ||
- liblapack | ||
- wget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is wget needed in host? I would assume it’s more likely to be a build dependency? (Build if it’s used for downloads, host if you link against it)
if it is being used for downloads, they should probably be included in the sources section instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I think you are right - it will only be needed in build
- fixed!
if it is being used for downloads, they should probably be included in the sources section instead
I'm going to assume you meant "build:
section" here as well - please correct me if you meant something else
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@conda-forge/staged-recipes, ready for re-review |
1 similar comment
@conda-forge/staged-recipes, ready for re-review |
@conda-forge/staged-recipes @chrisburr , ready for re-review |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).