Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ossfs #15612

Merged
merged 10 commits into from
Jul 20, 2021
Merged

Add ossfs #15612

merged 10 commits into from
Jul 20, 2021

Conversation

karajan1001
Copy link
Contributor

@karajan1001 karajan1001 commented Jul 13, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ossfs) and found it was in an excellent condition.

@efiop efiop mentioned this pull request Jul 13, 2021
2 tasks
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ossfs) and found some lint.

Here's what I've got...

For recipes/ossfs:

  • Recipe maintainer "efoip" does not exist

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ossfs) and found it was in an excellent condition.

@efiop
Copy link
Member

efiop commented Jul 13, 2021

GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.

I confirm 🙂

1. solve the problem of install error
- pip
- python
run:
- oss2 ==2.6.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karajan1001 Should we relax this to >= here and in original project?

@efiop
Copy link
Member

efiop commented Jul 16, 2021

@conda-forge/staged-recipes Hey guys, just a very gentle ping that this is now ready to be reviewed when you have time. 🙂

recipes/ossfs/meta.yaml Outdated Show resolved Hide resolved
recipes/ossfs/meta.yaml Outdated Show resolved Hide resolved
karajan1001 and others added 3 commits July 19, 2021 08:32
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ossfs) and found some lint.

Here's what I've got...

For recipes/ossfs:

  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ossfs) and found some lint.

Here's what I've got...

For recipes/ossfs:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ossfs) and found it was in an excellent condition.

@efiop
Copy link
Member

efiop commented Jul 19, 2021

@ocefpaf Thanks again for the help! Ready for another round of reviews 🙂

@efiop
Copy link
Member

efiop commented Jul 20, 2021

@conda-forge/staged-recipes Hey guys, just a very gentle ping that this is now ready to be reviewed when you have time. 🙂

@dopplershift dopplershift merged commit 144832c into conda-forge:master Jul 20, 2021
@karajan1001 karajan1001 deleted the add_ossfs branch July 21, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants