oss: migrate to ossfs #6307
Merged
oss: migrate to ossfs #6307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix 6177
pass all of the tests
1. Experiments shows resumable get/put has little influnence on performance. 2. Just use resumable ones as default
1. Bump ossfs from 2021.6.2 to 2021.7.0 2. add some comments to the verification trigger
Because some problem with oss-emulater 1. bump to ossfs 2021.7.1 2. rewrite upload_fobj
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
isidentical
reviewed
Jul 13, 2021
|
Now that we are using the real OSS, do we need this? dvc/tests/func/test_data_cloud.py Lines 35 to 41 in f45311e |
|
@isidentical Great catch, indeed we don't need it anymore. We can safely remove xfail now. |
Because we didn't use emulator, we can remove some pytest XFAILs
|
Thank you @karajan1001 ! 🙏 For the record: now waiting for conda package conda-forge/staged-recipes#15612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6177, migrate to ossfs
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
come from #6178
Performance summary:
The results from the current version compare to reuse of sessions optimization.
The results from the current version compare to reuse of sessions optimization.