Add recipe for OCW #1606

jarifibrahim · 2016-09-16T15:07:31Z

No description provided.

conda-forge-linter · 2016-09-16T15:07:36Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ocw) and found it was in an excellent condition.

jarifibrahim · 2016-09-16T15:54:19Z

@agoodm Can you please help me fix the failing build?

lewismc · 2016-09-16T17:42:09Z

Nice work @jarifibrahim

conda.resolve.NoPackagesFound: Packages/dependencies missing in current osx-64 channels: 

  - ocw 1.2.0 py27_0 -> esgf-pyclient >=0.1.6

  - ocw 1.2.0 py27_0 -> myproxyclient >=1.4.3

  - ocw 1.2.0 py27_0 -> podaacpy >=1.0.2

  - podaacpy >=1.0.2

  - myproxyclient >=1.4.3

  - esgf-pyclient >=0.1.6

agoodm · 2016-09-16T17:52:11Z

@jarifibrahim Thank you for getting this done so soon!
The cause of these error messages is that some of the dependencies are not available on the main anaconda or conda-forge channels. This means that we will need to make PRs to upload recipes for esgf-pyclient, myproxyclient, and podaacpy. I think @lewismc might want to handle the latter, but I can go ahead and do the other two.

jarifibrahim · 2016-09-16T17:57:04Z

@agoodm I see these packages on anaconda
esgf-pyclient - https://anaconda.org/birdhouse/esgf-pyclient
myproxyclient - https://anaconda.org/birdhouse/myproxyclient
Both the packages are available only for python 2

The following are from the Travis build log.

File "/Users/travis/miniconda/lib/python3.5/site-packages/conda/resolve.py", line 454, in verify_specs
    raise NoPackagesFound(bad_deps)
conda.resolve.NoPackagesFound: Packages/dependencies missing in current osx-64 channels: 
  - ocw 1.2.0 py27_0 -> esgf-pyclient >=0.1.6

In the above snippet python 3 is used for building conda recipe.

Fetching package metadata .........
Resolving distributions from 1 recipes... 
Computed that there are 3 distributions from the 1 recipes:
Resolved dependencies, will be built in the following order: 
    ocw-1.2.0-py27_0 (will be built: True)
    ocw-1.2.0-py34_0 (will be built: True)
    ocw-1.2.0-py35_0 (will be built: True)

Is there any way to build ocw conda package only for python 2? The ocw is not compatible with python 3 at this moment.

agoodm · 2016-09-16T18:15:09Z

@jarifibrahim I was referring to the main anaconda channel and the conda-forge channel. Those packages are available on my own channel as well, but I believe they need to at least be on the conda-forge channel in order to not cause a CI build failure. As for the python3 question I am not exactly sure at the moment myself. Someone in the conda-forge org might know.

jarifibrahim · 2016-09-16T18:19:32Z

@agoodm Right. That means we'll have to add esgf-pyclient and myproxyclient to conda-forge as well. I'll push new PRs today. Thanks!

agoodm

Is this necessary? I don't recall seeing other recipe feedstocks containing standalone LICENSE files.

agoodm

@jarifibrahim Please read the attached review.

Thanks,m

agoodm · 2016-09-16T21:37:54Z

recipes/ocw/meta.yaml

+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+


@jarifibrahim You'll need to get rid of all comments in the final staged recipe, including the license headers. You'll need to do the same for the other PRs you have made if you haven't done so already.

agoodm · 2016-09-16T21:39:45Z

recipes/ocw/meta.yaml

+
+source:
+  git_url: https://github.com/apache/climate.git
+


This should probably be changed to point to PyPi, with md5 hash and all. Additionally leaving it like this will get the latest code from our master ocw branch rather than a stable release which is not what we want.

agoodm · 2016-09-16T21:40:17Z

recipes/ocw/meta.yaml

+# under the License.
+
+{% set name = "ocw" %}
+{% set version = "1.2.0" %}


Should be version 1.1.0, as 1.2.0 is not released yet.

agoodm · 2016-09-16T21:40:46Z

recipes/ocw/meta.yaml

+
+about:
+  home: http://climate.apache.org/
+  license: Apache License


Should be "Apache License, Version 2.0"

conda-forge-linter · 2016-09-17T15:52:21Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ocw) and found some lint.

Here's what I've got...

For recipes/ocw:

Failed to even lint the recipe (might be a conda-smithy bug) 😢

conda-forge-linter · 2016-09-17T15:57:04Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ocw) and found it was in an excellent condition.

jakirkham · 2016-09-17T16:32:15Z

recipes/ocw/meta.yaml

+
+about:
+  home: http://climate.apache.org/
+  license: Apache License, Version 2.0


So we at conda-forge prefer the shortened license form. So Apache 2.0 or similar.

Please ask upstream to add the license file to MANIFEST.in. Also please add an xref in a comment in the recipe so we can track this and update accordingly once the license is packaged in the sdist. We are trying to ensure license files are included in the built packages.

Also can optionally add license_family: Apache.

jakirkham · 2016-09-17T16:36:31Z

recipes/ocw/meta.yaml

+
+extra:
+  recipe-maintainers:
+    - agoodm


Are you ok with being a maintainer of climate at conda-forge, @agoodm?

@jakirkham Yes I am.

jakirkham · 2016-09-17T16:37:20Z

recipes/ocw/meta.yaml

+build:
+  skip: True  # [py3k]
+  number: 0
+  script: python setup.py install


Please add the arguments --single-version-externally-managed --record record.txt. These are required when using setuptools to make sure this gets packaged correctly.

jakirkham · 2016-09-17T16:39:27Z

recipes/ocw/meta.yaml

+
+about:
+  home: http://climate.apache.org/
+  license: Apache License, Version 2.0


Also can optionally add license_family: Apache.

jakirkham

Thanks for putting this together, @jarifibrahim.

A few comments to get this cleaned up. Noting some dependencies are not here yet, but I see they are being worked on other PRs. We can come back to this once they are packaged.

jakirkham · 2016-10-19T03:52:17Z

Are you taking this over somewhere else @agoodm ? Should this stay open?

agoodm · 2016-10-19T03:58:49Z

@jakirkham go ahead and close this. Since this PR is rather cluttered I think it would be best for me to start from a new one.

jakirkham · 2016-10-19T04:40:46Z

Continued in PR ( #1784 ).

agoodm suggested changes Sep 16, 2016

View reviewed changes

Add recipe for OCW

44db94d

jakirkham reviewed Sep 17, 2016

View reviewed changes

agoodm mentioned this pull request Oct 19, 2016

Add ocw recipe #1784

Merged

jakirkham closed this Oct 19, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recipe for OCW #1606

Add recipe for OCW #1606

jarifibrahim commented Sep 16, 2016

conda-forge-linter commented Sep 16, 2016

jarifibrahim commented Sep 16, 2016

lewismc commented Sep 16, 2016

agoodm commented Sep 16, 2016

jarifibrahim commented Sep 16, 2016 •

edited

agoodm commented Sep 16, 2016

jarifibrahim commented Sep 16, 2016

agoodm left a comment

agoodm left a comment

agoodm Sep 16, 2016

jarifibrahim Sep 17, 2016

agoodm Sep 16, 2016

jarifibrahim Sep 17, 2016

agoodm Sep 16, 2016

jarifibrahim Sep 17, 2016

agoodm Sep 16, 2016

jarifibrahim Sep 17, 2016

conda-forge-linter commented Sep 17, 2016

conda-forge-linter commented Sep 17, 2016

jakirkham Sep 17, 2016 •

edited

jakirkham Sep 17, 2016 •

edited

jakirkham Sep 17, 2016

jakirkham Sep 17, 2016 •

edited

agoodm Sep 17, 2016

jakirkham Sep 17, 2016

jakirkham Sep 17, 2016

jakirkham left a comment

jakirkham commented Oct 19, 2016

agoodm commented Oct 19, 2016

jakirkham commented Oct 19, 2016

Add recipe for OCW #1606

Add recipe for OCW #1606

Conversation

jarifibrahim commented Sep 16, 2016

conda-forge-linter commented Sep 16, 2016

jarifibrahim commented Sep 16, 2016

lewismc commented Sep 16, 2016

agoodm commented Sep 16, 2016

jarifibrahim commented Sep 16, 2016 • edited

agoodm commented Sep 16, 2016

jarifibrahim commented Sep 16, 2016

agoodm left a comment

Choose a reason for hiding this comment

agoodm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-linter commented Sep 17, 2016

conda-forge-linter commented Sep 17, 2016

jakirkham Sep 17, 2016 • edited

Choose a reason for hiding this comment

jakirkham Sep 17, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham Sep 17, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham left a comment

Choose a reason for hiding this comment

jakirkham commented Oct 19, 2016

agoodm commented Oct 19, 2016

jakirkham commented Oct 19, 2016

jarifibrahim commented Sep 16, 2016 •

edited

jakirkham Sep 17, 2016 •

edited

jakirkham Sep 17, 2016 •

edited

jakirkham Sep 17, 2016 •

edited