Add ocw recipe #1784
Add ocw recipe #1784
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| about: | ||
| home: http://climate.apache.org/ | ||
| license: Apache 2.0 | ||
| # license_file: LICENSE.txt |
| - myproxyclient | ||
| - webtest | ||
| - esgf-pyclient | ||
| # - podaacpy >= 1.4.0 |
There was a problem hiding this comment.
This was left commented as a reminder that it will be needed when 1.2.0 is released, but this recipe is for 1.1.0 which doesn't need it.
| - bottle | ||
| - pydap | ||
| - python-dateutil | ||
| - mock |
There was a problem hiding this comment.
Do we need mock at run time? Is this being used for something other than tests?
There was a problem hiding this comment.
Good point. This was all copied/pasted from the first recipe I wrote which was from a generic list of dependencies intended for developers, not users. I will remove this and webtest.
| - python-dateutil | ||
| - mock | ||
| - myproxyclient | ||
| - webtest |
|
I addressed most of the comments with the last commit. |
|
Also, Python 3 compatibility won't be addressed until the 1.2.0 release, which seems to be why the CI tests are failing. Is this a necessary requirement before uploading a package to conda-forge? |
|
Correct @agoodm , I am working on Python support for Pydap and then I think we can release Pydap, then OCW 1.2.0, then we will have Python 2.7 and 3.2-3.5 support in OCW 1.2.0. |
|
Never mind, I forgot that you can exclude Python 3 builds in the recipe itself. Is there anything else I am missing, @jakirkham ? |
|
Is this good to merge, @jakirkham ? |
|
This is good to go @agoodm. You can address the remaining issue in the feedstock. |
Take since 2 of #1606. I have added
LICENCE.txttoMANIFEST.inupstream, but it won't be in the source distribution until the 1.2.0 release so I left that section commented out. Same with thepodaacpydependency.