Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add click-help-colors #1696

Merged
merged 2 commits into from
Oct 4, 2016
Merged

Add click-help-colors #1696

merged 2 commits into from
Oct 4, 2016

Conversation

saketkc
Copy link
Member

@saketkc saketkc commented Oct 3, 2016

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/click-help-colors) and found it was in an excellent condition.

about:
home: https://github.com/r-m-n/click-help-colors
license: MIT
license_file: LICENSE.txt
Copy link
Member

@synapticarbors synapticarbors Oct 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LICENSE.txt file is not included in the package on pypi.io since the project is missing a MANIFEST.in file. Comment out this line and add a comment to add this later once it appears upstream. You might also raise an issue on the issue tracker for the project. This is what is causing the build to fail currently.

build:
- python
- setuptools
- click
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think you need click to build the package, so remove this line.

license_file: LICENSE.txt
summary: 'Colorization of help messages in Click'
license_family: MIT

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add dev_url: https://github.com/r-m-n/click-help-colors in the about section

@saketkc
Copy link
Member Author

saketkc commented Oct 4, 2016

Thanks @synapticarbors, updated.

@synapticarbors synapticarbors merged commit 4f038b4 into conda-forge:master Oct 4, 2016
@synapticarbors
Copy link
Member

@saketkc - Thanks for contributing this recipe. Soon you should get an email that invites you to join conda-forge. Once accepted you will be added to a team with the same name as this recipe. This will give you permissions on the feedstock (repo) for this recipe.

Make sure when proposing any change that you go through the typical GitHub workflow of forking the feedstock and making changes in your fork that you PR back. Once merged CIs will build and deploy any changes you make.

Please let us know if you have any questions and welcome to conda-forge.

@saketkc
Copy link
Member Author

saketkc commented Oct 4, 2016

Thanks a lot @synapticarbors! Look forward to contributing more actively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants